diff options
| author | rkc <rkc@chromium.org> | 2015-04-28 10:28:52 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-04-28 17:29:35 +0000 |
| commit | 02b1b8c1ece6c0d533373c3efae3ac31b1319427 (patch) | |
| tree | 2ed536562c8225c5a8206e10f0ed125ac6eae3ba /device/BUILD.gn | |
| parent | fefb7cfcf73c07b5f2774266bda02e839a829ef1 (diff) | |
| download | chromium_src-02b1b8c1ece6c0d533373c3efae3ac31b1319427.zip chromium_src-02b1b8c1ece6c0d533373c3efae3ac31b1319427.tar.gz chromium_src-02b1b8c1ece6c0d533373c3efae3ac31b1319427.tar.bz2 | |
Revert of Revert of Add CPP API for BLE advertisments. (patchset #1 id:1 of https://codereview.chromium.org/1111563002/)
Reason for revert:
Can't seem to find any bots this was failing on. Trybots on the original CL that had component=shared_library are working fine and locally it builds fine too.
Original issue's description:
> Revert of Add CPP API for BLE advertisments. (patchset #12 id:220001 of https://codereview.chromium.org/1054743003/)
>
> Reason for revert:
> Breaks component=shared_library build (missing export?)
>
> ../../device/bluetooth/bluetooth_adapter_chromeos.cc:321: error: undefined reference to 'chromeos::BluetoothAdvertisementChromeOS::BluetoothAdvertisementChromeOS(scoped_ptr<device::BluetoothAdvertisement::Data, base::DefaultDeleter<device::BluetoothAdvertisement::Data> >, scoped_refptr<chromeos::BluetoothAdapterChromeOS>)'
> ../../base/memory/scoped_ptr.h:128: error: undefined reference to 'device::BluetoothAdvertisement::Data::~Data()'
> ../../device/bluetooth/bluetooth_adapter_chromeos.cc:322: error: undefined reference to 'chromeos::BluetoothAdvertisementChromeOS::Register(base::Callback<void ()> const&, base::Callback<void (device::BluetoothAdvertisement::ErrorCode)> const&)'
> obj/device/bluetooth/device_bluetooth.bluetooth_adapter_chromeos.o(.debug_addr+0x6f20): error: undefined reference to 'chromeos::BluetoothAdvertisementChromeOS::Register(base::Callback<void ()> const&, base::Callback<void (device::BluetoothAdvertisement::ErrorCode)> const&)'
>
> Original issue's description:
> > Add CPP API for BLE advertisments.
> >
> > This CL adds the new classes, changes to existing classes and tests for adding
> > the CPP API for LE advertisements. The design for this is available at
> > http://go/chrome-ble-advertising.
> >
> > R=armansito@chromium.org, jamuraa@chromium.org
> > BUG=466375
> >
> > Committed: https://crrev.com/c96da18077ef4b5ab28cb8b2684cd84386075e5a
> > Cr-Commit-Position: refs/heads/master@{#327128}
>
> TBR=armansito@chromium.org,jamuraa@chromium.org,scheib@chromium.org,rkc@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=466375
>
> Committed: https://crrev.com/28bc6bec94e67f23a6a9a16490e6bdf721cf6b27
> Cr-Commit-Position: refs/heads/master@{#327155}
TBR=armansito@chromium.org,jamuraa@chromium.org,scheib@chromium.org,spang@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=466375
Review URL: https://codereview.chromium.org/1108403002
Cr-Commit-Position: refs/heads/master@{#327316}
Diffstat (limited to 'device/BUILD.gn')
| -rw-r--r-- | device/BUILD.gn | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/device/BUILD.gn b/device/BUILD.gn index ba52290..dfd8550 100644 --- a/device/BUILD.gn +++ b/device/BUILD.gn @@ -20,6 +20,7 @@ test("device_unittests") { "bluetooth/bluetooth_adapter_profile_chromeos_unittest.cc", "bluetooth/bluetooth_adapter_unittest.cc", "bluetooth/bluetooth_adapter_win_unittest.cc", + "bluetooth/bluetooth_advertisement_chromeos_unittest.cc", "bluetooth/bluetooth_audio_sink_chromeos_unittest.cc", "bluetooth/bluetooth_chromeos_unittest.cc", "bluetooth/bluetooth_device_unittest.cc", |