summaryrefslogtreecommitdiffstats
path: root/device/bluetooth/bluetooth_classic_device_mac.mm
diff options
context:
space:
mode:
authorjosephsih <josephsih@chromium.org>2016-02-24 02:17:23 -0800
committerCommit bot <commit-bot@chromium.org>2016-02-24 10:18:54 +0000
commit098a1cd80c1398b4bea2c1bc83c5dca686b5b42d (patch)
tree8551038fb7319e42b419d444651827ead956a6a5 /device/bluetooth/bluetooth_classic_device_mac.mm
parent3f96177578cf0511174d42546a70660cc8d6eeeb (diff)
downloadchromium_src-098a1cd80c1398b4bea2c1bc83c5dca686b5b42d.zip
chromium_src-098a1cd80c1398b4bea2c1bc83c5dca686b5b42d.tar.gz
chromium_src-098a1cd80c1398b4bea2c1bc83c5dca686b5b42d.tar.bz2
Determine device type via bluetooth appearance in OOBE
In OOBE, the device type is determined exclusively based on the bluetooth class. However, some keyboards do not advertise the bluetooth class. Instead, the bluetooth appearance is advertised. This patch utilizes the bluetooth appearance to determine the device type if the bluetooth class information is missing. Note that this patch only takes effect on keyboard-less devices such as Mickey and Monroe. BUG=578337, 546616 TEST=Execute the steps below: 1. Let a keyboard-less device boot into OOBE. 2. Unfold Microsoft Universal Foldable Keyboard to power it on. 3. Press Func 1 key on the keyboard for a few seconds until its back light begins blinking. 4. Press "OS" key on the top right corner a few times until Android logo lights on. 3. Observe the pairing takes effect and asks the user to type the pin code. (Without this patch, the pairing never takes effect since the particular keyboard is not considered as a keyboard.) Review URL: https://codereview.chromium.org/1656253002 Cr-Commit-Position: refs/heads/master@{#377257}
Diffstat (limited to 'device/bluetooth/bluetooth_classic_device_mac.mm')
-rw-r--r--device/bluetooth/bluetooth_classic_device_mac.mm7
1 files changed, 7 insertions, 0 deletions
diff --git a/device/bluetooth/bluetooth_classic_device_mac.mm b/device/bluetooth/bluetooth_classic_device_mac.mm
index d1c3f63..985596e 100644
--- a/device/bluetooth/bluetooth_classic_device_mac.mm
+++ b/device/bluetooth/bluetooth_classic_device_mac.mm
@@ -102,6 +102,13 @@ uint16_t BluetoothClassicDeviceMac::GetDeviceID() const {
return 0;
}
+uint16_t BluetoothClassicDeviceMac::GetAppearance() const {
+ // TODO(crbug.com/588083): Implementing GetAppearance()
+ // on mac, win, and android platforms for chrome
+ NOTIMPLEMENTED();
+ return 0;
+}
+
bool BluetoothClassicDeviceMac::IsPaired() const {
return [device_ isPaired];
}