diff options
author | mek <mek@chromium.org> | 2016-03-10 21:36:27 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-03-11 05:37:56 +0000 |
commit | 6cad14e7709b9578100415a641ec1ea3f0268e27 (patch) | |
tree | 8caf46194f07243bc10b4d1160f24c6ee28da8f9 /device/bluetooth/bluetooth_gatt_characteristic.h | |
parent | a74e913fbf2aeb1e70d86914997aeab14b535005 (diff) | |
download | chromium_src-6cad14e7709b9578100415a641ec1ea3f0268e27.zip chromium_src-6cad14e7709b9578100415a641ec1ea3f0268e27.tar.gz chromium_src-6cad14e7709b9578100415a641ec1ea3f0268e27.tar.bz2 |
Cleanup TrialToken in preparation of moving it to content/common.
This includes the following cleanups:
- Pass StringPiece by value rather than const ref, as its documentation
suggests.
- Represent origins as url::Origin/blink::WebSecurityOrigin.
- Pass feature_name to TrialToken::IsAppropriate and related methods as
StringPiece. Currently doesn't make a difference yet as TrialTokenValidator
still converts through std::string, but that can be fixed, and new content
side code can avoid having to construct strings for feature names this way.
- Store expiry time as base::Time instead of raw int64. Under the hood a
base::Time is an int64 anyway, so this just moves the conversion from int64
to base::Time earlier, making the code more accurately reflect what it
represents.
- C-style cast in passing int64 to base::Time::FromDoubleT is against the
style guide, and unnecessary since this is done implicitly by the compiler.
- Fix order of methods in trial_token.cc to match that in trial_token.h
- Use correct style for argument names in trial_token.h (featureName =>
feature_name).
BUG=590873
Review URL: https://codereview.chromium.org/1752463002
Cr-Commit-Position: refs/heads/master@{#380537}
Diffstat (limited to 'device/bluetooth/bluetooth_gatt_characteristic.h')
0 files changed, 0 insertions, 0 deletions