diff options
| author | reillyg <reillyg@chromium.org> | 2014-09-12 23:15:04 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-09-13 06:18:44 +0000 |
| commit | 7b245aba250436867e5fd4dff77c08b9c5dc1a9d (patch) | |
| tree | 40453f723181c18848ac05b449ae614061f9ad64 /device/hid/hid_connection_mac.h | |
| parent | 2191196d13b2896f5ba7bc1c6a3371cb86a7e8eb (diff) | |
| download | chromium_src-7b245aba250436867e5fd4dff77c08b9c5dc1a9d.zip chromium_src-7b245aba250436867e5fd4dff77c08b9c5dc1a9d.tar.gz chromium_src-7b245aba250436867e5fd4dff77c08b9c5dc1a9d.tar.bz2 | |
Do not open or close IOHIDManager's IOHIDDeviceRefs.
The IOHIDManager object manages the IOHIDDevice instances that it
creates. Calling IOHIDDeviceOpen on such an instance is a no-op and
calling IOHIDDeviceClose prevents the IOHIDManager from tracking the
lifetime of the device. The solution is to never open nor close these
devices.
BUG=413976
Review URL: https://codereview.chromium.org/568873003
Cr-Commit-Position: refs/heads/master@{#294735}
Diffstat (limited to 'device/hid/hid_connection_mac.h')
| -rw-r--r-- | device/hid/hid_connection_mac.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/device/hid/hid_connection_mac.h b/device/hid/hid_connection_mac.h index 81153b6..7282760 100644 --- a/device/hid/hid_connection_mac.h +++ b/device/hid/hid_connection_mac.h @@ -62,7 +62,7 @@ class HidConnectionMac : public HidConnection { base::ScopedCFTypeRef<IOHIDDeviceRef> device_; scoped_refptr<base::MessageLoopProxy> message_loop_; - scoped_ptr<uint8_t[]> inbound_buffer_; + std::vector<uint8_t> inbound_buffer_; std::queue<PendingHidReport> pending_reports_; std::queue<PendingHidRead> pending_reads_; |