Clean up HID backend and API.

The Mac backend no longer creates its own thread and instead simply enforces single-threaded usage on any thread which supports I/O. Ref management has also been sanitized.

The Linux backend now implements feature report support.

The backend interface no longer expects implicit report IDs in buffers passed to Write or SetFeatureReport. Instead these interfaces (as well as GetFeatureReport) take explicit report ID arguments.

The API interface has been updated to reflect the improved report ID treatment.

Finally, the API also now exposes opaque device identifiers on enumeration, rather than exposing raw system paths or other information that could be potentially sensitive.

BUG=347294

Review URL: https://codereview.chromium.org/161823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253853 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 6 insertions, 10 deletions

diff --git a/device/hid/hid_service_win.h b/device/hid/hid_service_win.h
index 428420e..8f18765 100644
--- a/device/hid/hid_service_win.h
+++ b/device/hid/hid_service_win.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -6,18 +6,13 @@
 #define DEVICE_HID_HID_SERVICE_WIN_H_
 
 #include <map>
-#include <string>
-#include <vector>
 
-#include "base/basictypes.h"
-#include "base/memory/ref_counted.h"
 #include "device/hid/hid_device_info.h"
 #include "device/hid/hid_service.h"
 
 namespace device {
 
 class HidConnection;
-class HidService;
 
 class HidServiceWin : public HidService {
  public:
@@ -25,14 +20,15 @@ class HidServiceWin : public HidService {
 
   virtual void GetDevices(std::vector<HidDeviceInfo>* devices) OVERRIDE;
 
-  virtual scoped_refptr<HidConnection> Connect(std::string device_id) OVERRIDE;
+  virtual scoped_refptr<HidConnection> Connect(const HidDeviceId& device_id)
+      OVERRIDE;
 
  private:
   virtual ~HidServiceWin();
 
-  bool Enumerate();
-  void PlatformAddDevice(std::string device_path);
-  void PlatformRemoveDevice(std::string device_path);
+  void Enumerate();
+  void PlatformAddDevice(const std::string& device_path);
+  void PlatformRemoveDevice(const std::string& device_path);
 
   DISALLOW_COPY_AND_ASSIGN(HidServiceWin);
 };