diff options
author | dcheng <dcheng@chromium.org> | 2014-10-22 16:07:52 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-10-22 23:08:15 +0000 |
commit | b5aaf402eb4783b9f62de3ae8485edec343866cc (patch) | |
tree | e9f30bd26479007ce31da6833f81743109eba9b4 /device/serial/data_source_sender.h | |
parent | 9cee6105930e94ad2abf2c004efb1d65c0759a0f (diff) | |
download | chromium_src-b5aaf402eb4783b9f62de3ae8485edec343866cc.zip chromium_src-b5aaf402eb4783b9f62de3ae8485edec343866cc.tar.gz chromium_src-b5aaf402eb4783b9f62de3ae8485edec343866cc.tar.bz2 |
Standardize usage of virtual/override/final in device/
The Google C++ style guide states:
Explicitly annotate overrides of virtual functions or virtual
destructors with an override or (less frequently) final specifier.
Older (pre-C++11) code will use the virtual keyword as an inferior
alternative annotation. For clarity, use exactly one of override,
final, or virtual when declaring an override.
To better conform to these guidelines, the following constructs have
been rewritten:
- if a base class has a virtual destructor, then:
virtual ~Foo(); -> ~Foo() override;
- virtual void Foo() override; -> void Foo() override;
- virtual void Foo() override final; -> void Foo() final;
This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.
BUG=417463
TBR=keybuk@chromium.org
Review URL: https://codereview.chromium.org/663203007
Cr-Commit-Position: refs/heads/master@{#300790}
Diffstat (limited to 'device/serial/data_source_sender.h')
-rw-r--r-- | device/serial/data_source_sender.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/device/serial/data_source_sender.h b/device/serial/data_source_sender.h index 59782aa..9020a97 100644 --- a/device/serial/data_source_sender.h +++ b/device/serial/data_source_sender.h @@ -38,13 +38,13 @@ class DataSourceSender : public base::RefCounted<DataSourceSender>, friend class base::RefCounted<DataSourceSender>; class PendingSend; - virtual ~DataSourceSender(); + ~DataSourceSender() override; // mojo::InterfaceImpl<serial::DataSourceSender> overrides. - virtual void Init(mojo::ScopedDataPipeProducerHandle handle) override; - virtual void Resume() override; + void Init(mojo::ScopedDataPipeProducerHandle handle) override; + void Resume() override; // Invoked in the event of a connection error. Calls DispatchFatalError(). - virtual void OnConnectionError() override; + void OnConnectionError() override; // Starts waiting for |handle_| to be ready for writes. void StartWaiting(); |