diff options
| author | sammc <sammc@chromium.org> | 2015-02-04 00:53:51 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-02-04 08:54:34 +0000 |
| commit | 4b7484b40acaec1d7904c5f38bd4be116468013a (patch) | |
| tree | fd1de1e8203ea228c53fdd22280d1d0fc7d816eb /device/serial/serial_connection.h | |
| parent | 332f0228d0231cf7b3c7d9bdbc4b9c3d35e9899c (diff) | |
| download | chromium_src-4b7484b40acaec1d7904c5f38bd4be116468013a.zip chromium_src-4b7484b40acaec1d7904c5f38bd4be116468013a.tar.gz chromium_src-4b7484b40acaec1d7904c5f38bd4be116468013a.tar.bz2 | |
Revert of Remove Client= from device/serial/data_stream.mojom. (patchset #1 id:20001 of https://codereview.chromium.org/889283002/)
Reason for revert:
Switching to two pipes broke FIFO assumption, causing DataSinkTest.CancelDuringError and SerialConnectionTest.Cancel to become flaky
Original issue's description:
> Remove Client= from device/serial/data_stream.mojom.
>
> BUG=451321
>
> Committed: https://crrev.com/bc78a2320b50eba4fe397f1f838a82ad30b16cd6
> Cr-Commit-Position: refs/heads/master@{#314231}
TBR=rockot@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=451321
Review URL: https://codereview.chromium.org/873293006
Cr-Commit-Position: refs/heads/master@{#314524}
Diffstat (limited to 'device/serial/serial_connection.h')
| -rw-r--r-- | device/serial/serial_connection.h | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/device/serial/serial_connection.h b/device/serial/serial_connection.h index 6143c8b..d0b940f 100644 --- a/device/serial/serial_connection.h +++ b/device/serial/serial_connection.h @@ -22,9 +22,7 @@ class SerialConnection : public mojo::InterfaceImpl<serial::Connection> { public: SerialConnection(scoped_refptr<SerialIoHandler> io_handler, mojo::InterfaceRequest<serial::DataSink> sink, - mojo::InterfacePtr<serial::DataSinkClient> sink_client, - mojo::InterfaceRequest<serial::DataSource> source, - mojo::InterfacePtr<serial::DataSourceClient> source_client); + mojo::InterfaceRequest<serial::DataSource> source); ~SerialConnection() override; // mojo::InterfaceImpl<serial::Connection> overrides. |