summaryrefslogtreecommitdiffstats
path: root/device/usb/usb_device_filter_unittest.cc
diff options
context:
space:
mode:
authorreillyg <reillyg@chromium.org>2016-02-11 17:38:38 -0800
committerCommit bot <commit-bot@chromium.org>2016-02-12 01:39:46 +0000
commit54128082613544e4fa1fb2f0d6a367dea635c173 (patch)
tree9f4397351d773cbbbd66fef0ee5911497c64fec5 /device/usb/usb_device_filter_unittest.cc
parent0f8742a11a2ac76833ae1dc4dcdaa14086fbcf44 (diff)
downloadchromium_src-54128082613544e4fa1fb2f0d6a367dea635c173.zip
chromium_src-54128082613544e4fa1fb2f0d6a367dea635c173.tar.gz
chromium_src-54128082613544e4fa1fb2f0d6a367dea635c173.tar.bz2
Construct USB descriptors over explicit values.
Instead of specifying a bunch of arbitrary defaults and then updating them in the code building the structure. This makes them friendly to use with C++11's emplace_back() method. BUG=None Review URL: https://codereview.chromium.org/1468423003 Cr-Commit-Position: refs/heads/master@{#375081}
Diffstat (limited to 'device/usb/usb_device_filter_unittest.cc')
-rw-r--r--device/usb/usb_device_filter_unittest.cc11
1 files changed, 2 insertions, 9 deletions
diff --git a/device/usb/usb_device_filter_unittest.cc b/device/usb/usb_device_filter_unittest.cc
index 303ffa7..df1a223 100644
--- a/device/usb/usb_device_filter_unittest.cc
+++ b/device/usb/usb_device_filter_unittest.cc
@@ -20,15 +20,8 @@ using testing::Return;
class UsbFilterTest : public testing::Test {
public:
void SetUp() override {
- UsbInterfaceDescriptor interface;
- interface.interface_number = 1;
- interface.alternate_setting = 0;
- interface.interface_class = 0xFF;
- interface.interface_subclass = 0x42;
- interface.interface_protocol = 0x01;
-
- UsbConfigDescriptor config;
- config.interfaces.push_back(interface);
+ UsbConfigDescriptor config(1, false, false, 0);
+ config.interfaces.emplace_back(1, 0, 0xff, 0x42, 0x01);
android_phone_ = new MockUsbDevice(0x18d1, 0x4ee2, config);
}