summaryrefslogtreecommitdiffstats
path: root/device
diff options
context:
space:
mode:
authormorrita <morrita@chromium.org>2015-07-10 13:54:01 -0700
committerCommit bot <commit-bot@chromium.org>2015-07-10 20:54:41 +0000
commitc02ff720599da01dd4c96e3e6bda0020a24e1a45 (patch)
treed873a5e32e9bf223cb0ccf9a08db95b3377a0452 /device
parent8336888d95e672e8642889cade066aed7bb1f595 (diff)
downloadchromium_src-c02ff720599da01dd4c96e3e6bda0020a24e1a45.zip
chromium_src-c02ff720599da01dd4c96e3e6bda0020a24e1a45.tar.gz
chromium_src-c02ff720599da01dd4c96e3e6bda0020a24e1a45.tar.bz2
ChannelPosix: Robustly close FDs of deleting messages.
This CL explicitly calls CloseFileDescriptors() to deleting Messages so that their containing FDs are closed without PCHECK(). Before introducing PlatformFileAttachment, these FDs weren't close()-ed with PCHECK(), but PlatformFileAttachment closes them with PCHECK(), and has made closing invalid FDs fatal. This CL is a speculative crash fix for Mac, just relaxing the check. It doesn't fix the underlying, long-standing problem. Ideally we should track down how the FD got invalid. BUG=504050 R=agl@chromium.org,tsepez@chromium.org Review URL: https://codereview.chromium.org/1228713008 Cr-Commit-Position: refs/heads/master@{#338353}
Diffstat (limited to 'device')
0 files changed, 0 insertions, 0 deletions