device: Add out-of-line copy ctors for complex classes.

This patch adds out of line copy constructors for classes that our
clang-plugin considers heavy. This is an effort to enable copy
constructor checks by default.

BUG=436357
R=reillyg@chromium.org, dcheng@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/1729843003

Cr-Commit-Position: refs/heads/master@{#377367}

12 files changed, 36 insertions, 0 deletions

diff --git a/device/hid/hid_collection_info.cc b/device/hid/hid_collection_info.cc
index 4c55d08..43406de 100644
--- a/device/hid/hid_collection_info.cc
+++ b/device/hid/hid_collection_info.cc
@@ -11,6 +11,8 @@ HidCollectionInfo::HidCollectionInfo()
             HidUsageAndPage::kPageUndefined) {
 }
 
+HidCollectionInfo::HidCollectionInfo(const HidCollectionInfo& other) = default;
+
 HidCollectionInfo::~HidCollectionInfo() {
 }
 
diff --git a/device/hid/hid_collection_info.h b/device/hid/hid_collection_info.h
index 3b35e5e..05e40d7 100644
--- a/device/hid/hid_collection_info.h
+++ b/device/hid/hid_collection_info.h
@@ -13,6 +13,7 @@ namespace device {
 
 struct HidCollectionInfo {
   HidCollectionInfo();
+  HidCollectionInfo(const HidCollectionInfo& other);
   ~HidCollectionInfo();
 
   // Collection's usage ID.
diff --git a/device/hid/hid_connection.cc b/device/hid/hid_connection.cc
index 208a565..5a904fe 100644
--- a/device/hid/hid_connection.cc
+++ b/device/hid/hid_connection.cc
@@ -196,10 +196,14 @@ bool HidConnection::IsReportIdProtected(uint8_t report_id) {
 
 PendingHidReport::PendingHidReport() {}
 
+PendingHidReport::PendingHidReport(const PendingHidReport& other) = default;
+
 PendingHidReport::~PendingHidReport() {}
 
 PendingHidRead::PendingHidRead() {}
 
+PendingHidRead::PendingHidRead(const PendingHidRead& other) = default;
+
 PendingHidRead::~PendingHidRead() {}
 
 }  // namespace device
diff --git a/device/hid/hid_connection.h b/device/hid/hid_connection.h
index 9cc8aaf..1bf8d2e 100644
--- a/device/hid/hid_connection.h
+++ b/device/hid/hid_connection.h
@@ -97,6 +97,7 @@ class HidConnection : public base::RefCountedThreadSafe<HidConnection> {
 
 struct PendingHidReport {
   PendingHidReport();
+  PendingHidReport(const PendingHidReport& other);
   ~PendingHidReport();
 
   scoped_refptr<net::IOBuffer> buffer;
@@ -105,6 +106,7 @@ struct PendingHidReport {
 
 struct PendingHidRead {
   PendingHidRead();
+  PendingHidRead(const PendingHidRead& other);
   ~PendingHidRead();
 
   HidConnection::ReadCallback callback;
diff --git a/device/hid/input_service_linux.cc b/device/hid/input_service_linux.cc
index c39a73d..dd8b38b 100644
--- a/device/hid/input_service_linux.cc
+++ b/device/hid/input_service_linux.cc
@@ -166,6 +166,9 @@ InputServiceLinux::InputDeviceInfo::InputDeviceInfo()
       is_touchpad(false),
       is_touchscreen(false) {}
 
+InputServiceLinux::InputDeviceInfo::InputDeviceInfo(
+    const InputDeviceInfo& other) = default;
+
 InputServiceLinux::InputServiceLinux() {
 }
 
diff --git a/device/hid/input_service_linux.h b/device/hid/input_service_linux.h
index dfb11d1..ca395b0 100644
--- a/device/hid/input_service_linux.h
+++ b/device/hid/input_service_linux.h
@@ -30,6 +30,7 @@ class InputServiceLinux : public base::MessageLoop::DestructionObserver {
     enum Type { TYPE_BLUETOOTH, TYPE_USB, TYPE_SERIO, TYPE_UNKNOWN };
 
     InputDeviceInfo();
+    InputDeviceInfo(const InputDeviceInfo& other);
 
     std::string id;
     std::string name;
diff --git a/device/usb/usb_descriptors.cc b/device/usb/usb_descriptors.cc
index 6defda8..d3ef4bf 100644
--- a/device/usb/usb_descriptors.cc
+++ b/device/usb/usb_descriptors.cc
@@ -102,6 +102,9 @@ UsbEndpointDescriptor::UsbEndpointDescriptor(
       usage_type(usage_type),
       polling_interval(polling_interval) {}
 
+UsbEndpointDescriptor::UsbEndpointDescriptor(
+    const UsbEndpointDescriptor& other) = default;
+
 UsbEndpointDescriptor::~UsbEndpointDescriptor() = default;
 
 UsbInterfaceDescriptor::UsbInterfaceDescriptor(uint8_t interface_number,
@@ -115,6 +118,9 @@ UsbInterfaceDescriptor::UsbInterfaceDescriptor(uint8_t interface_number,
       interface_subclass(interface_subclass),
       interface_protocol(interface_protocol) {}
 
+UsbInterfaceDescriptor::UsbInterfaceDescriptor(
+    const UsbInterfaceDescriptor& other) = default;
+
 UsbInterfaceDescriptor::~UsbInterfaceDescriptor() = default;
 
 UsbConfigDescriptor::UsbConfigDescriptor(uint8_t configuration_value,
@@ -126,6 +132,9 @@ UsbConfigDescriptor::UsbConfigDescriptor(uint8_t configuration_value,
       remote_wakeup(remote_wakeup),
       maximum_power(maximum_power) {}
 
+UsbConfigDescriptor::UsbConfigDescriptor(const UsbConfigDescriptor& other) =
+    default;
+
 UsbConfigDescriptor::~UsbConfigDescriptor() = default;
 
 bool ParseUsbStringDescriptor(const std::vector<uint8_t>& descriptor,
diff --git a/device/usb/usb_descriptors.h b/device/usb/usb_descriptors.h
index c99a6de..ba7169a 100644
--- a/device/usb/usb_descriptors.h
+++ b/device/usb/usb_descriptors.h
@@ -57,6 +57,7 @@ struct UsbEndpointDescriptor {
                         UsbUsageType usage_type,
                         uint16_t polling_interval);
   UsbEndpointDescriptor() = delete;
+  UsbEndpointDescriptor(const UsbEndpointDescriptor& other);
   ~UsbEndpointDescriptor();
 
   uint8_t address;
@@ -76,6 +77,7 @@ struct UsbInterfaceDescriptor {
                          uint8_t interface_subclass,
                          uint8_t interface_protocol);
   UsbInterfaceDescriptor() = delete;
+  UsbInterfaceDescriptor(const UsbInterfaceDescriptor& other);
   ~UsbInterfaceDescriptor();
 
   uint8_t interface_number;
@@ -93,6 +95,7 @@ struct UsbConfigDescriptor {
                       bool remote_wakeup,
                       uint16_t maximum_power);
   UsbConfigDescriptor() = delete;
+  UsbConfigDescriptor(const UsbConfigDescriptor& other);
   ~UsbConfigDescriptor();
 
   uint8_t configuration_value;
diff --git a/device/usb/usb_device_filter.cc b/device/usb/usb_device_filter.cc
index b8d47fa..52d1356 100644
--- a/device/usb/usb_device_filter.cc
+++ b/device/usb/usb_device_filter.cc
@@ -30,6 +30,8 @@ UsbDeviceFilter::UsbDeviceFilter()
       interface_protocol_set_(false) {
 }
 
+UsbDeviceFilter::UsbDeviceFilter(const UsbDeviceFilter& other) = default;
+
 UsbDeviceFilter::~UsbDeviceFilter() {
 }
 
diff --git a/device/usb/usb_device_filter.h b/device/usb/usb_device_filter.h
index 8455304..05f4038 100644
--- a/device/usb/usb_device_filter.h
+++ b/device/usb/usb_device_filter.h
@@ -23,6 +23,7 @@ class UsbDevice;
 class UsbDeviceFilter {
  public:
   UsbDeviceFilter();
+  UsbDeviceFilter(const UsbDeviceFilter& other);
   ~UsbDeviceFilter();
 
   void SetVendorId(uint16_t vendor_id);
diff --git a/device/usb/webusb_descriptors.cc b/device/usb/webusb_descriptors.cc
index 27a3d38..de2309e 100644
--- a/device/usb/webusb_descriptors.cc
+++ b/device/usb/webusb_descriptors.cc
@@ -359,11 +359,17 @@ void OnReadBosDescriptorHeader(scoped_refptr<UsbDeviceHandle> device_handle,
 
 WebUsbFunctionSubset::WebUsbFunctionSubset() : first_interface(0) {}
 
+WebUsbFunctionSubset::WebUsbFunctionSubset(const WebUsbFunctionSubset& other) =
+    default;
+
 WebUsbFunctionSubset::~WebUsbFunctionSubset() {}
 
 WebUsbConfigurationSubset::WebUsbConfigurationSubset()
     : configuration_value(0) {}
 
+WebUsbConfigurationSubset::WebUsbConfigurationSubset(
+    const WebUsbConfigurationSubset& other) = default;
+
 WebUsbConfigurationSubset::~WebUsbConfigurationSubset() {}
 
 WebUsbAllowedOrigins::WebUsbAllowedOrigins() {}
diff --git a/device/usb/webusb_descriptors.h b/device/usb/webusb_descriptors.h
index 44f9c1c..516adfc 100644
--- a/device/usb/webusb_descriptors.h
+++ b/device/usb/webusb_descriptors.h
@@ -18,6 +18,7 @@ class UsbDeviceHandle;
 
 struct WebUsbFunctionSubset {
   WebUsbFunctionSubset();
+  WebUsbFunctionSubset(const WebUsbFunctionSubset& other);
   ~WebUsbFunctionSubset();
 
   uint8_t first_interface;
@@ -27,6 +28,7 @@ struct WebUsbFunctionSubset {
 
 struct WebUsbConfigurationSubset {
   WebUsbConfigurationSubset();
+  WebUsbConfigurationSubset(const WebUsbConfigurationSubset& other);
   ~WebUsbConfigurationSubset();
 
   uint8_t configuration_value;