diff options
| author | dcheng <dcheng@chromium.org> | 2016-02-26 19:51:32 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-02-27 03:53:04 +0000 |
| commit | 794d2bd77811b6d6b45048c19c287075cc9930db (patch) | |
| tree | ef71bf3826d396a488ef0c72a68b3d7f4ff236d3 /docs/ipc_fuzzer.md | |
| parent | 47dc6a8a0f7d36d20f90df5ac62da075d45bc9c3 (diff) | |
| download | chromium_src-794d2bd77811b6d6b45048c19c287075cc9930db.zip chromium_src-794d2bd77811b6d6b45048c19c287075cc9930db.tar.gz chromium_src-794d2bd77811b6d6b45048c19c287075cc9930db.tar.bz2 | |
Make extensions::DictionaryBuilder and extensions::ListValue unmovable.
There's no reason for these classes to be movable. std::move() is just
being used as a synonym for Build().
In addition:
- Build() is fewer characters than std::move().
- clang-format works better when builder syntax is consistently used,
which makes it easier for readers to visually match up deeply nested
builders.
- It's surprising to see std::move() used with what looks like a
temporary.
BUG=none
Review URL: https://codereview.chromium.org/1739183003
Cr-Commit-Position: refs/heads/master@{#378107}
Diffstat (limited to 'docs/ipc_fuzzer.md')
0 files changed, 0 insertions, 0 deletions