diff options
| author | jamescook@chromium.org <jamescook@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-17 07:05:49 +0000 |
|---|---|---|
| committer | jamescook@chromium.org <jamescook@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-17 07:05:49 +0000 |
| commit | 2db9e7b656a6361bb02ef9e950fa20893a8b57ac (patch) | |
| tree | 72ec74450c79dbc80fb38f0f285587f989c6ce6a /extensions/DEPS | |
| parent | 0fdadd2b77d86406046dbd3bf1e4b8b097d1c503 (diff) | |
| download | chromium_src-2db9e7b656a6361bb02ef9e950fa20893a8b57ac.zip chromium_src-2db9e7b656a6361bb02ef9e950fa20893a8b57ac.tar.gz chromium_src-2db9e7b656a6361bb02ef9e950fa20893a8b57ac.tar.bz2 | |
Refactor code that defers extension background page loading
src/extensions depends on chrome::NOTIFICATION_PROFILE_CREATED to support deferred loading of extension background pages when the profile isn't ready yet. This is a layering violation.
* Remove Chrome concepts like "browser window ready" and "profile created" from ProcessManager. Introduce ProcessManagerDelegate with a general concept of deferring background page loading.
* Consolidate all the tricky Chrome-specific background page loading rules into ChromeProcessManagerDelegate. This keeps all the rules in one place. Annotate each block of special case code with the bug that inspired it.
* Extend unit test coverage for ProcessManager.
This will make it easier to eliminate chrome::NOTIFICATION_PROFILE_DESTROYED in ProcessManager in a later CL.
BUG=392658
TEST=unit_tests ProcessManagerTest, browser_tests ProcessManagerBrowserTest, manual
Review URL: https://codereview.chromium.org/381283002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283678 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'extensions/DEPS')
| -rw-r--r-- | extensions/DEPS | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/extensions/DEPS b/extensions/DEPS index 0505b02..4077a55 100644 --- a/extensions/DEPS +++ b/extensions/DEPS @@ -1,4 +1,5 @@ include_rules = [ + # Do not add Chrome dependencies. Much work went into removing them. "+components/url_matcher", "+content/public/common", "+content/public/test", @@ -13,7 +14,7 @@ include_rules = [ # NOTE: Please do not add includes without talking to the app shell team; # see OWNERS for this directory. # - # TODO(jamescook): Remove these. http://crbug.com/162530 + # TODO(jamescook): Remove this. http://crbug.com/392622 "!chrome/browser/chrome_notification_types.h", ] |