diff options
| author | ananta <ananta@chromium.org> | 2015-05-04 11:50:57 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-05-04 18:51:45 +0000 |
| commit | cef8cfb15b65361aa256f9ec37029fd5f11bcaf8 (patch) | |
| tree | 9bc8ecd4f44bfdfbaa4cd97fd7404cb081ce6df0 /extensions/DEPS | |
| parent | 58869145d30e8a7d11dc9bb654b81a2e3245ff5b (diff) | |
| download | chromium_src-cef8cfb15b65361aa256f9ec37029fd5f11bcaf8.zip chromium_src-cef8cfb15b65361aa256f9ec37029fd5f11bcaf8.tar.gz chromium_src-cef8cfb15b65361aa256f9ec37029fd5f11bcaf8.tar.bz2 | |
Revert of Ensure that the DirectWrite font cache works in Chrome canary on Windows 8+ with AppContainer prote… (patchset #14 id:260001 of https://codereview.chromium.org/1105763004/)
Reason for revert:
This patch causes a perf regression bug during renderer startup which is triggered when the cache is not available. Will send out a new patch which addresses both issues.
The perf bug is here:-
https://code.google.com/p/chromium/issues/detail?id=483443
Original issue's description:
> Ensure that the DirectWrite font cache works in Chrome canary on Windows 8+ with AppContainer protection.
>
> The DirectWrite font cache is mapped as a shared section by the renderer processes. The browser creates
> the section. On Windows 8+ with AppContainer protection the renderers are unable to open this shared section
> as the BaseNamedObjects object directory is virtualized to \Sessions\SessionId\AppContainerNamedObjects.
>
> This effectively means that the renderers now fallback to the old method of enumerating all fonts while DirectWrite
> builds up its font cache. This hurts performance.
>
> Proposed fix is as below :-
> 1. When the renderer process is launched we get notified in the RenderProcessHost::OnProcessLaunched method.
> We send a control IPC message here ViewMsg_FontCacheSectionHandle which contains the duplicated font cache
> section handle.
>
> 2. The ViewMsg_FontCacheSectionHandle message is handled by RenderThreadImpl. It ensures that the shared handle
> is set by calling a helper function SetFontCacheSectionHandle. This function then triggers the setting of the
> DirectWrite font factory in skia.
>
> 3. Some of the code in the WarmupDirectWrite function is no longer needed like the code to create the font factory
> and create some fonts to warm up DirectWrite. This is because DirectWrite in the renderer now uses the custom
> font collection which means that most of the code now can run in the sandbox. The only parts which need to run
> outside the sandbox are the loading of the dwrite.dll and the code in the FontCollectionLoader which reads fonts
> from the registry.
>
> 4. The GetPreSandboxWarmupFontMgr helper function has been renamed to GetDirectWriteFontManager.
>
> The UMA metric DirectWrite.Fonts.LoadTime.Cached should be available if the font cache is loaded in the renderer.
>
> BUG=481285
> R=cpu
>
> Committed: https://crrev.com/bbca53aa082320e13909d995a9af66bed7de69a8
> Cr-Commit-Position: refs/heads/master@{#327804}
TBR=cpu@chromium.org,scottmg@chromium.org,shrikant@chromium.org,scheib@chromium.org,palmer@chromium.org,piman@chromium.org,creis@chromium.org,avi@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=481285
Review URL: https://codereview.chromium.org/1127673002
Cr-Commit-Position: refs/heads/master@{#328160}
Diffstat (limited to 'extensions/DEPS')
| -rw-r--r-- | extensions/DEPS | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/extensions/DEPS b/extensions/DEPS index 61251ff..285b7d3 100644 --- a/extensions/DEPS +++ b/extensions/DEPS @@ -13,8 +13,6 @@ include_rules = [ "+grit/extensions_renderer_resources.h", "+grit/extensions_resources.h", "+testing", - "+sandbox/win/src/sandbox.h", - "+sandbox/win/src/sandbox_policy.h", "+third_party/mojo/src/mojo/public", "+third_party/skia/include", |