diff options
| author | rockot <rockot@chromium.org> | 2014-08-27 16:52:48 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-08-27 23:54:06 +0000 |
| commit | 5ad6c89c9721d23519c062919d1d2c951aaea921 (patch) | |
| tree | d777b54e32b8d2182997432c9134cac45f17eb8b /extensions/browser/api/extensions_api_client.h | |
| parent | 57722ec5e7cc0020fe065e172c578190b520502d (diff) | |
| download | chromium_src-5ad6c89c9721d23519c062919d1d2c951aaea921.zip chromium_src-5ad6c89c9721d23519c062919d1d2c951aaea921.tar.gz chromium_src-5ad6c89c9721d23519c062919d1d2c951aaea921.tar.bz2 | |
Fix HidService lifetime issues.
This reverts HidService to a singleton instance, adding two gross
and presently hard-to-avoid properties:
1. Its instance getter takes a UI message loop proxy
2. Its lifetime is bound by the message loop of its origin thread
The purpose of this is to preserve the necessary threading discipline
required by both the chrome.hid API implementation and the
permission_broker DBus client while ensuring that the HidService is
created and destroyed on the same thread.
BUG=401234
Review URL: https://codereview.chromium.org/464753002
Cr-Commit-Position: refs/heads/master@{#292273}
Diffstat (limited to 'extensions/browser/api/extensions_api_client.h')
| -rw-r--r-- | extensions/browser/api/extensions_api_client.h | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/extensions/browser/api/extensions_api_client.h b/extensions/browser/api/extensions_api_client.h index 4a60df5..d2e07b7 100644 --- a/extensions/browser/api/extensions_api_client.h +++ b/extensions/browser/api/extensions_api_client.h @@ -19,10 +19,6 @@ namespace content { class BrowserContext; } -namespace device { -class HidService; -} - namespace extensions { class AppViewGuestDelegate; @@ -76,9 +72,6 @@ class ExtensionsAPIClient { // Creates the AppViewGuestDelegate. virtual AppViewGuestDelegate* CreateAppViewGuestDelegate() const; - // Returns the HidService instance for this embedder. - virtual device::HidService* GetHidService(); - // Returns a delegate for some of WebViewGuest's behavior. The caller owns the // returned WebViewGuestDelegate. virtual WebViewGuestDelegate* CreateWebViewGuestDelegate ( |