summaryrefslogtreecommitdiffstats
path: root/extensions/browser/api
diff options
context:
space:
mode:
authorrob <rob@robwu.nl>2016-02-15 03:06:26 -0800
committerCommit bot <commit-bot@chromium.org>2016-02-15 11:07:13 +0000
commitaefd358f97ba1a4462e4853b9ce4a3e340c6efba (patch)
treeb319fe48695e16d4c21f70dbfdaa9e915eb7fd99 /extensions/browser/api
parente8b36a62043b0998bc06cc6e0a317fbec14c628b (diff)
downloadchromium_src-aefd358f97ba1a4462e4853b9ce4a3e340c6efba.zip
chromium_src-aefd358f97ba1a4462e4853b9ce4a3e340c6efba.tar.gz
chromium_src-aefd358f97ba1a4462e4853b9ce4a3e340c6efba.tar.bz2
Remove "experimental-html" from chrome.app.window
The "experimental-html" frame option is behind a flag, undocumented and seems not used by real app developers. Review URL: https://codereview.chromium.org/1690893003 Cr-Commit-Position: refs/heads/master@{#375443}
Diffstat (limited to 'extensions/browser/api')
-rw-r--r--extensions/browser/api/app_window/app_window_api.cc18
-rw-r--r--extensions/browser/api/app_window/app_window_api.h2
2 files changed, 1 insertions, 19 deletions
diff --git a/extensions/browser/api/app_window/app_window_api.cc b/extensions/browser/api/app_window/app_window_api.cc
index d7def0f..3e9f45f 100644
--- a/extensions/browser/api/app_window/app_window_api.cc
+++ b/extensions/browser/api/app_window/app_window_api.cc
@@ -75,8 +75,6 @@ const char kImeWindowMustBeImeWindowOrPanel[] =
} // namespace app_window_constants
const char kNoneFrameOption[] = "none";
- // TODO(benwells): Remove HTML titlebar injection.
-const char kHtmlFrameOption[] = "experimental-html";
namespace {
@@ -124,8 +122,7 @@ void CopyBoundsSpec(const app_window::BoundsSpecification* input_spec,
} // namespace
-AppWindowCreateFunction::AppWindowCreateFunction()
- : inject_html_titlebar_(false) {}
+AppWindowCreateFunction::AppWindowCreateFunction() {}
bool AppWindowCreateFunction::RunAsync() {
// Don't create app window if the system is shutting down.
@@ -198,8 +195,6 @@ bool AppWindowCreateFunction::RunAsync() {
result->Set("frameId", new base::FundamentalValue(frame_id));
existing_window->GetSerializedState(result);
result->SetBoolean("existingWindow", true);
- // TODO(benwells): Remove HTML titlebar injection.
- result->SetBoolean("injectTitlebar", false);
SetResult(result);
SendResponse(true);
return true;
@@ -360,8 +355,6 @@ bool AppWindowCreateFunction::RunAsync() {
base::DictionaryValue* result = new base::DictionaryValue;
result->Set("frameId", new base::FundamentalValue(frame_id));
- result->Set("injectTitlebar",
- new base::FundamentalValue(inject_html_titlebar_));
result->Set("id", new base::StringValue(app_window->window_key()));
app_window->GetSerializedState(result);
SetResult(result);
@@ -503,15 +496,6 @@ bool AppWindowCreateFunction::GetBoundsSpec(
AppWindow::Frame AppWindowCreateFunction::GetFrameFromString(
const std::string& frame_string) {
- if (frame_string == kHtmlFrameOption &&
- (extension()->permissions_data()->HasAPIPermission(
- APIPermission::kExperimental) ||
- base::CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kEnableExperimentalExtensionApis))) {
- inject_html_titlebar_ = true;
- return AppWindow::FRAME_NONE;
- }
-
if (frame_string == kNoneFrameOption)
return AppWindow::FRAME_NONE;
diff --git a/extensions/browser/api/app_window/app_window_api.h b/extensions/browser/api/app_window/app_window_api.h
index f70aecb..f10ec98 100644
--- a/extensions/browser/api/app_window/app_window_api.h
+++ b/extensions/browser/api/app_window/app_window_api.h
@@ -36,8 +36,6 @@ class AppWindowCreateFunction : public AsyncExtensionFunction {
const extensions::api::app_window::CreateWindowOptions& options,
AppWindow::CreateParams* create_params);
void UpdateFrameOptionsForChannel(AppWindow::CreateParams* create_params);
-
- bool inject_html_titlebar_;
};
} // namespace extensions