Extensions: Minor cleanup, formatting/lint errors.

1. Added missing STL header includes.
2. Whitespace fixup.
3. Proper ordering of forward declarations and header includes.
4. Using FRIEND_TEST_ALL_PREFIXES to eliminate test-only method.
5. Switched to range-based for loops.

Review URL: https://codereview.chromium.org/1786163002

Cr-Commit-Position: refs/heads/master@{#381098}

2 files changed, 9 insertions, 10 deletions

diff --git a/extensions/browser/api/extensions_api_client.cc b/extensions/browser/api/extensions_api_client.cc
index 8426436..7eb174f 100644
--- a/extensions/browser/api/extensions_api_client.cc
+++ b/extensions/browser/api/extensions_api_client.cc
@@ -31,8 +31,7 @@ void ExtensionsAPIClient::AddAdditionalValueStoreCaches(
     const scoped_refptr<SettingsStorageFactory>& factory,
     const scoped_refptr<base::ObserverListThreadSafe<SettingsObserver>>&
         observers,
-    std::map<settings_namespace::Namespace, ValueStoreCache*>* caches) {
-}
+    std::map<settings_namespace::Namespace, ValueStoreCache*>* caches) {}
 
 void ExtensionsAPIClient::AttachWebContentsHelpers(
     content::WebContents* web_contents) const {
diff --git a/extensions/browser/api/extensions_api_client.h b/extensions/browser/api/extensions_api_client.h
index c367906..ca50ba8 100644
--- a/extensions/browser/api/extensions_api_client.h
+++ b/extensions/browser/api/extensions_api_client.h
@@ -38,16 +38,16 @@ class ExtensionOptionsGuestDelegate;
 class ManagementAPIDelegate;
 class MimeHandlerViewGuest;
 class MimeHandlerViewGuestDelegate;
-class WebViewGuest;
-class WebViewGuestDelegate;
-class WebViewPermissionHelper;
-class WebViewPermissionHelperDelegate;
-class WebRequestEventRouterDelegate;
 class RulesCacheDelegate;
 class SettingsObserver;
 class SettingsStorageFactory;
 class ValueStoreCache;
 class VirtualKeyboardDelegate;
+class WebRequestEventRouterDelegate;
+class WebViewGuest;
+class WebViewGuestDelegate;
+class WebViewPermissionHelper;
+class WebViewPermissionHelperDelegate;
 
 // Allows the embedder of the extensions module to customize its support for
 // API features. The embedder must create a single instance in the browser
@@ -97,14 +97,14 @@ class ExtensionsAPIClient {
 
   // Returns a delegate for some of WebViewGuest's behavior. The caller owns the
   // returned WebViewGuestDelegate.
-  virtual WebViewGuestDelegate* CreateWebViewGuestDelegate (
+  virtual WebViewGuestDelegate* CreateWebViewGuestDelegate(
       WebViewGuest* web_view_guest) const;
 
   // Returns a delegate for some of WebViewPermissionHelper's behavior. The
   // caller owns the returned WebViewPermissionHelperDelegate.
   virtual WebViewPermissionHelperDelegate*
-      CreateWebViewPermissionHelperDelegate (
-          WebViewPermissionHelper* web_view_permission_helper) const;
+  CreateWebViewPermissionHelperDelegate(
+      WebViewPermissionHelper* web_view_permission_helper) const;
 
   // Creates a delegate for WebRequestEventRouter.
   virtual WebRequestEventRouterDelegate* CreateWebRequestEventRouterDelegate()