diff options
| author | bokan <bokan@chromium.org> | 2015-02-03 15:23:39 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-02-03 23:24:29 +0000 |
| commit | 107a47faa8f7e9c38cd0e7aeac74751b103df215 (patch) | |
| tree | 2d902d3f5e7d9632c1c007b4ae11175f7c56f14e /extensions/browser/app_window | |
| parent | 8da6aa6d5f5d4000fa733df814e83ff57da56dca (diff) | |
| download | chromium_src-107a47faa8f7e9c38cd0e7aeac74751b103df215.zip chromium_src-107a47faa8f7e9c38cd0e7aeac74751b103df215.tar.gz chromium_src-107a47faa8f7e9c38cd0e7aeac74751b103df215.tar.bz2 | |
Rename initial_pos to initial_rect in ShowWidget and ShowView IPCs.
These IPCs hold this param as a gfx::Rect and the RenderWidget and RenderView
set the size. On the receiving end, the size is sometimes used so initial_pos
was a misnomer.
This is a mechanical rename, there should be no functional difference.
TBR=
BUG=
Review URL: https://codereview.chromium.org/889403004
Cr-Commit-Position: refs/heads/master@{#314430}
Diffstat (limited to 'extensions/browser/app_window')
| -rw-r--r-- | extensions/browser/app_window/app_delegate.h | 2 | ||||
| -rw-r--r-- | extensions/browser/app_window/app_window.cc | 4 | ||||
| -rw-r--r-- | extensions/browser/app_window/app_window.h | 2 |
3 files changed, 4 insertions, 4 deletions
diff --git a/extensions/browser/app_window/app_delegate.h b/extensions/browser/app_window/app_delegate.h index 70f9f12..36bcc92 100644 --- a/extensions/browser/app_window/app_delegate.h +++ b/extensions/browser/app_window/app_delegate.h @@ -50,7 +50,7 @@ class AppDelegate { virtual void AddNewContents(content::BrowserContext* context, content::WebContents* new_contents, WindowOpenDisposition disposition, - const gfx::Rect& initial_pos, + const gfx::Rect& initial_rect, bool user_gesture, bool* was_blocked) = 0; diff --git a/extensions/browser/app_window/app_window.cc b/extensions/browser/app_window/app_window.cc index fe9b758..9256228d 100644 --- a/extensions/browser/app_window/app_window.cc +++ b/extensions/browser/app_window/app_window.cc @@ -373,14 +373,14 @@ WebContents* AppWindow::OpenURLFromTab(WebContents* source, void AppWindow::AddNewContents(WebContents* source, WebContents* new_contents, WindowOpenDisposition disposition, - const gfx::Rect& initial_pos, + const gfx::Rect& initial_rect, bool user_gesture, bool* was_blocked) { DCHECK(new_contents->GetBrowserContext() == browser_context_); app_delegate_->AddNewContents(browser_context_, new_contents, disposition, - initial_pos, + initial_rect, user_gesture, was_blocked); } diff --git a/extensions/browser/app_window/app_window.h b/extensions/browser/app_window/app_window.h index 3eef866..8d6ffea 100644 --- a/extensions/browser/app_window/app_window.h +++ b/extensions/browser/app_window/app_window.h @@ -394,7 +394,7 @@ class AppWindow : public content::NotificationObserver, void AddNewContents(content::WebContents* source, content::WebContents* new_contents, WindowOpenDisposition disposition, - const gfx::Rect& initial_pos, + const gfx::Rect& initial_rect, bool user_gesture, bool* was_blocked) override; bool PreHandleKeyboardEvent(content::WebContents* source, |