diff options
| author | ricea <ricea@chromium.org> | 2015-09-25 11:45:13 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-09-25 18:46:07 +0000 |
| commit | c700927282ae201df4e0938cfbaeefa4a96bfc80 (patch) | |
| tree | 2eb3e9ad671e2b9c1aaa53de210c568ffe2301c8 /extensions/browser/app_window | |
| parent | 1c5d55a1edfc5da9f019e866ab426064ea292d40 (diff) | |
| download | chromium_src-c700927282ae201df4e0938cfbaeefa4a96bfc80.zip chromium_src-c700927282ae201df4e0938cfbaeefa4a96bfc80.tar.gz chromium_src-c700927282ae201df4e0938cfbaeefa4a96bfc80.tar.bz2 | |
Use the appropriate variant of IntToString in //extensions
Using the wrong variant of IntToString() can lead to unexpected
behaviour and bugs. Use the appropriate variant for the type being
converted.
No behaviour change intended.
BUG=505479
TEST=compiled
Review URL: https://codereview.chromium.org/1352893003
Cr-Commit-Position: refs/heads/master@{#350874}
Diffstat (limited to 'extensions/browser/app_window')
| -rw-r--r-- | extensions/browser/app_window/app_window_geometry_cache_unittest.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/extensions/browser/app_window/app_window_geometry_cache_unittest.cc b/extensions/browser/app_window/app_window_geometry_cache_unittest.cc index b35a543..1b42ec1 100644 --- a/extensions/browser/app_window/app_window_geometry_cache_unittest.cc +++ b/extensions/browser/app_window/app_window_geometry_cache_unittest.cc @@ -410,7 +410,7 @@ TEST_F(AppWindowGeometryCacheTest, MaxWindows) { gfx::Rect bounds(4, 5, 31, 43); gfx::Rect screen_bounds(0, 0, 1600, 900); for (size_t i = 0; i < AppWindowGeometryCache::kMaxCachedWindows + 1; ++i) { - std::string window_id = "window_" + base::IntToString(i); + std::string window_id = "window_" + base::SizeTToString(i); cache_->SaveGeometry( extension_id, window_id, bounds, screen_bounds, ui::SHOW_STATE_NORMAL); } @@ -419,7 +419,7 @@ TEST_F(AppWindowGeometryCacheTest, MaxWindows) { EXPECT_FALSE(cache_->GetGeometry(extension_id, "window_0", NULL, NULL, NULL)); // All other windows should still exist. for (size_t i = 1; i < AppWindowGeometryCache::kMaxCachedWindows + 1; ++i) { - std::string window_id = "window_" + base::IntToString(i); + std::string window_id = "window_" + base::SizeTToString(i); EXPECT_TRUE(cache_->GetGeometry(extension_id, window_id, NULL, NULL, NULL)); } } |