diff options
| author | asargent@chromium.org <asargent@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-22 23:33:54 +0000 |
|---|---|---|
| committer | asargent@chromium.org <asargent@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-22 23:33:54 +0000 |
| commit | 6a5898ed0fc7a089d26b6adb48aa70bde35916cf (patch) | |
| tree | 61ed7b7afe7f9e340ff1bf1d91201541a34bc6ab /extensions/browser/content_verifier_delegate.h | |
| parent | 8a22932d044abccb156885e72b61c3b57d1ba56c (diff) | |
| download | chromium_src-6a5898ed0fc7a089d26b6adb48aa70bde35916cf.zip chromium_src-6a5898ed0fc7a089d26b6adb48aa70bde35916cf.tar.gz chromium_src-6a5898ed0fc7a089d26b6adb48aa70bde35916cf.tar.bz2 | |
Content Verification: Don't access UI-thread objects on the IO thread
We ask to create ContentVerifyJob's on the IO thread as we read files
from extension directories, but we are accidentally accessing state that
lives on the UI thread (eg the ExtensionRegistry) while deciding whether
to do that or not.
This changes things so that as we discover extensions loading up, we
copy the data we need to make those decisions to an object on the IO
thread.
Also fix a bug that was keeping BOOTSTRAP mode from working, and one or
two other minor issues I found while I was staring at things.
BUG=395873,392216
Review URL: https://codereview.chromium.org/407043002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284804 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'extensions/browser/content_verifier_delegate.h')
| -rw-r--r-- | extensions/browser/content_verifier_delegate.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/extensions/browser/content_verifier_delegate.h b/extensions/browser/content_verifier_delegate.h index 5f5e57c..4d907cd 100644 --- a/extensions/browser/content_verifier_delegate.h +++ b/extensions/browser/content_verifier_delegate.h @@ -55,8 +55,8 @@ class ContentVerifierDelegate { virtual ~ContentVerifierDelegate() {} - // This should return true if the given extension should have its content - // verified. + // This should return what verification mode is appropriate for the given + // extension, if any. virtual Mode ShouldBeVerified(const Extension& extension) = 0; // Should return the public key to use for validating signatures via the two |