diff options
| author | dbeam <dbeam@chromium.org> | 2014-08-27 14:30:26 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-08-27 21:34:22 +0000 |
| commit | 9a5ab1949738fac262adbcf125004f7b1f62e7e9 (patch) | |
| tree | a00011cf1a56777584757037269b1b5e3edafb1a /extensions/browser/extension_error.cc | |
| parent | 56e39c64d4538396ce669727ae1dd0c462478f74 (diff) | |
| download | chromium_src-9a5ab1949738fac262adbcf125004f7b1f62e7e9.zip chromium_src-9a5ab1949738fac262adbcf125004f7b1f62e7e9.tar.gz chromium_src-9a5ab1949738fac262adbcf125004f7b1f62e7e9.tar.bz2 | |
Revert of Revert "Typecheck JS files for chrome://extensions" (patchset #1 of https://codereview.chromium.org/508283002/)
Reason for revert:
fixed check_licenses issues
Original issue's description:
> Revert "Typecheck JS files for chrome://extensions"
>
> This reverts commit 405253b7ee22ecb318d3c1ca9187e1e7259e704f.
>
> Caused a liscene failure on android bot:
> http://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/64664/steps/check_licenses/logs/stdio
>
> Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/87b3206
TBR=vitalyp@chromium.org,eroman@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/512003002
Cr-Commit-Position: refs/heads/master@{#292229}
Diffstat (limited to 'extensions/browser/extension_error.cc')
| -rw-r--r-- | extensions/browser/extension_error.cc | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/extensions/browser/extension_error.cc b/extensions/browser/extension_error.cc index d8733fe..19a31ea 100644 --- a/extensions/browser/extension_error.cc +++ b/extensions/browser/extension_error.cc @@ -158,6 +158,10 @@ RuntimeError::~RuntimeError() { } scoped_ptr<DictionaryValue> RuntimeError::ToValue() const { + // The items which are to be written into value are also described in + // chrome/browser/resources/extensions/extension_error_overlay.js in @typedef + // for RuntimeError and StackTrace. Please update them whenever you add or + // remove any keys here. scoped_ptr<DictionaryValue> value = ExtensionError::ToValue(); value->SetString(kContextUrlKey, context_url_.spec()); value->SetInteger(kRenderViewIdKey, render_view_id_); |