diff options
| author | oshima@chromium.org <oshima@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-18 22:23:23 +0000 |
|---|---|---|
| committer | oshima@chromium.org <oshima@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-18 22:23:23 +0000 |
| commit | 78a7a38fe796fdee9e476635b470ea43fa95ce7c (patch) | |
| tree | 811ea57184eb6ea3a9c066dd286c6389180ce634 /extensions/browser/extension_function_histogram_value.h | |
| parent | f9790db3deb08333fefa7699c671af128c484a9c (diff) | |
| download | chromium_src-78a7a38fe796fdee9e476635b470ea43fa95ce7c.zip chromium_src-78a7a38fe796fdee9e476635b470ea43fa95ce7c.tar.gz chromium_src-78a7a38fe796fdee9e476635b470ea43fa95ce7c.tar.bz2 | |
Revert 277929 "[fsp] Cleanup handling errors for operation reque..."
> [fsp] Cleanup handling errors for operation requests.
>
> This CL removes redundant internal functions which are identical, and replaces
> them with one.
>
> Moreover, the new general purpose error API function, passes now the entire
> value to the request manager. This is because, very soon, we are going to
> pass extra information with every error and success responses and we want to
> have access to them in the RequestManager.
>
> NOTRY=true
> TEST=unit_tests, browser_tests: *FileSystemProvider*
> BUG=373165, 384201
>
> Review URL: https://codereview.chromium.org/335753004
TBR=mtomasz@chromium.org
Review URL: https://codereview.chromium.org/342003004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278186 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'extensions/browser/extension_function_histogram_value.h')
| -rw-r--r-- | extensions/browser/extension_function_histogram_value.h | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/extensions/browser/extension_function_histogram_value.h b/extensions/browser/extension_function_histogram_value.h index 0de3dfc..e764408 100644 --- a/extensions/browser/extension_function_histogram_value.h +++ b/extensions/browser/extension_function_histogram_value.h @@ -776,7 +776,7 @@ enum HistogramValue { DELETED_BLUETOOTH_GET_SOCKETS, FILESYSTEMPROVIDER_UNMOUNT, FILESYSTEMPROVIDERINTERNAL_UNMOUNTREQUESTEDSUCCESS, - DELETED_FILESYSTEMPROVIDERINTERNAL_UNMOUNTREQUESTEDERROR, + FILESYSTEMPROVIDERINTERNAL_UNMOUNTREQUESTEDERROR, MEDIAGALLERIES_DROPPERMISSIONFORMEDIAFILESYSTEM, WEBCAMPRIVATE_SET, WEBCAMPRIVATE_RESET, @@ -809,7 +809,7 @@ enum HistogramValue { WEBSTOREPRIVATE_SIGNINFUNCTION, SHELL_CREATEWINDOW, FILESYSTEMPROVIDERINTERNAL_GETMETADATAREQUESTEDSUCCESS, - DELETED_FILESYSTEMPROVIDERINTERNAL_GETMETADATAREQUESTEDERROR, + FILESYSTEMPROVIDERINTERNAL_GETMETADATAREQUESTEDERROR, BROWSER_OPENTAB, MANAGEMENT_CREATEAPPSHORTCUT, WEBVIEW_SHOWCONTEXTMENU, @@ -819,19 +819,19 @@ enum HistogramValue { HOTWORDPRIVATE_SETHOTWORDSESSIONSTATE, HOTWORDPRIVATE_NOTIFYHOTWORDRECOGNITION, FILESYSTEMPROVIDERINTERNAL_READDIRECTORYREQUESTEDSUCCESS, - DELETED_FILESYSTEMPROVIDERINTERNAL_READDIRECTORYREQUESTEDERROR, + FILESYSTEMPROVIDERINTERNAL_READDIRECTORYREQUESTEDERROR, LEDGER_BATCHEXECUTE, FILESYSTEMPROVIDERINTERNAL_OPENFILEREQUESTEDSUCCESS, - DELETED_FILESYSTEMPROVIDERINTERNAL_OPENFILEREQUESTEDERROR, + FILESYSTEMPROVIDERINTERNAL_OPENFILEREQUESTEDERROR, FILESYSTEMPROVIDERINTERNAL_CLOSEFILEREQUESTEDSUCCESS, - DELETED_FILESYSTEMPROVIDERINTERNAL_CLOSEFILEREQUESTEDERROR, + FILESYSTEMPROVIDERINTERNAL_CLOSEFILEREQUESTEDERROR, SYNCEDNOTIFICATIONSPRIVATE_GETINITIALDATA, SYNCEDNOTIFICATIONSPRIVATE_UPDATENOTIFICATION, SYNCEDNOTIFICATIONSPRIVATE_SETRENDERCONTEXT, IDENTITY_GETACCOUNTS, FILEBROWSERPRIVATE_RESOLVEISOLATEDENTRIES, FILESYSTEMPROVIDERINTERNAL_READFILEREQUESTEDSUCCESS, - DELETED_FILESYSTEMPROVIDERINTERNAL_READFILEREQUESTEDERROR, + FILESYSTEMPROVIDERINTERNAL_READFILEREQUESTEDERROR, NETWORKINGPRIVATE_GETNETWORKS, WEBVIEW_SETNAME, ENTERPRISE_PLATFORMKEYSINTERNAL_GENERATEKEY, @@ -850,7 +850,6 @@ enum HistogramValue { INPUTMETHODPRIVATE_SETCURRENTINPUTMETHOD, INPUTMETHODPRIVATE_GETINPUTMETHODS, IDENTITY_GETPROFILEUSERINFO, - FILESYSTEMPROVIDERINTERNAL_OPERATIONREQUESTEDERROR, // Last entry: Add new entries above and ensure to update // tools/metrics/histograms/histograms/histograms.xml. ENUM_BOUNDARY |