diff options
| author | mgiuca <mgiuca@chromium.org> | 2015-04-23 22:59:21 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-04-24 05:59:24 +0000 |
| commit | 927270474a2720c30ee0bef9d19e25267344da36 (patch) | |
| tree | e3caffb1d15dcacffe18724ceb88d7cc29674cfc /extensions/browser/extension_prefs.cc | |
| parent | f83db42d42fe8b672e13316c54110d4cf2315828 (diff) | |
| download | chromium_src-927270474a2720c30ee0bef9d19e25267344da36.zip chromium_src-927270474a2720c30ee0bef9d19e25267344da36.tar.gz chromium_src-927270474a2720c30ee0bef9d19e25267344da36.tar.bz2 | |
Added CHECKs for null pointers in ChromeAppSorting.
These are designed to give us more information about production-only
crashes occurring in ChromeAppSorting. These checks should help narrow
down the times at which extension_scoped_prefs_ is null.
Added TODOs to remove most of the checks later (although I plan to leave
one in as a safeguard).
BUG=476648
Review URL: https://codereview.chromium.org/1055453007
Cr-Commit-Position: refs/heads/master@{#326746}
Diffstat (limited to 'extensions/browser/extension_prefs.cc')
| -rw-r--r-- | extensions/browser/extension_prefs.cc | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/extensions/browser/extension_prefs.cc b/extensions/browser/extension_prefs.cc index c4f7da2..c7409b3 100644 --- a/extensions/browser/extension_prefs.cc +++ b/extensions/browser/extension_prefs.cc @@ -1866,7 +1866,11 @@ ExtensionPrefs::ExtensionPrefs( app_sorting_(app_sorting.Pass()), time_provider_(time_provider.Pass()), extensions_disabled_(extensions_disabled) { + // TODO(mgiuca): Added these checks to try and diagnose + // http://crbug.com/476648. Remove them after the investigation is concluded. + CHECK(this); app_sorting_->SetExtensionScopedPrefs(this); + app_sorting_->CheckExtensionScopedPrefs(); MakePathsRelative(); // Ensure that any early observers are watching before prefs are initialized. |