[Extensions OOPI] Update ErrorConsole and related to use RenderFrameHosts

Update ErrorConsole-related things, including adding runtime errors and the
developerPrivate API to use RenderFrameHosts.
Remove the message listener for console messages from TabHelper, since it should
be fully handled in ChromeExtensionWebContentsObserver.
Remove unneeded ExtensionError::ToValue code.

BUG=455776
BUG=503676

Review URL: https://codereview.chromium.org/1202753002

Cr-Commit-Position: refs/heads/master@{#335961}

1 files changed, 12 insertions, 1 deletions

diff --git a/extensions/browser/extension_web_contents_observer.h b/extensions/browser/extension_web_contents_observer.h
index 266c0bf..c92ad9c 100644
--- a/extensions/browser/extension_web_contents_observer.h
+++ b/extensions/browser/extension_web_contents_observer.h
@@ -70,10 +70,21 @@ class ExtensionWebContentsObserver
   void PepperInstanceCreated() override;
   void PepperInstanceDeleted() override;
 
+  // Returns the extension id associated with the given |render_frame_host|, or
+  // the empty string if there is none.
+  std::string GetExtensionIdFromFrame(
+      content::RenderFrameHost* render_frame_host) const;
+
+  // Returns the extension associated with the given |render_frame_host|, or
+  // null if there is none.
+  const Extension* GetExtensionFromFrame(
+      content::RenderFrameHost* render_frame_host) const;
+
+  // TODO(devlin): Remove these once callers are updated to use the FromFrame
+  // equivalents.
   // Returns the extension or app associated with a render view host. Returns
   // NULL if the render view host is not for a valid extension.
   const Extension* GetExtension(content::RenderViewHost* render_view_host);
-
   // Returns the extension or app ID associated with a render view host. Returns
   // the empty string if the render view host is not for a valid extension.
   static std::string GetExtensionId(content::RenderViewHost* render_view_host);