diff options
| author | mlamouri <mlamouri@chromium.org> | 2016-02-17 01:54:11 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-02-17 09:56:11 +0000 |
| commit | a8e32b6fc3a4696ba24c8d6f257ec3fe848cf940 (patch) | |
| tree | 836ee36c4e54f1492191a58f2128aa552f8238d0 /extensions/browser/guest_view | |
| parent | a43b7f7e2bba472b853d47dddfcfefe7bc9d2248 (diff) | |
| download | chromium_src-a8e32b6fc3a4696ba24c8d6f257ec3fe848cf940.zip chromium_src-a8e32b6fc3a4696ba24c8d6f257ec3fe848cf940.tar.gz chromium_src-a8e32b6fc3a4696ba24c8d6f257ec3fe848cf940.tar.bz2 | |
Remove user gesture bit from PermissionContext code.
This CL removes the user gesture bit from PermissionContext and all its sub classes.
The user gesture information was required by the permission bubble code. With bug 545476
fixed, this is no longer needed.
This CL is the first CL in a suite of three CL that remove the passing of the user gesture
information from the renderer process content layer to the browser process chrome layer:
1. <this>
2. https://codereview.chromium.org/1695953002
3. https://codereview.chromium.org/1696883004
BUG=423770
Review URL: https://codereview.chromium.org/1695943002
Cr-Commit-Position: refs/heads/master@{#375839}
Diffstat (limited to 'extensions/browser/guest_view')
3 files changed, 1 insertions, 4 deletions
diff --git a/extensions/browser/guest_view/web_view/web_view_permission_helper.cc b/extensions/browser/guest_view/web_view/web_view_permission_helper.cc index 3ce5dd9..b0b140e 100644 --- a/extensions/browser/guest_view/web_view/web_view_permission_helper.cc +++ b/extensions/browser/guest_view/web_view/web_view_permission_helper.cc @@ -267,10 +267,9 @@ void WebViewPermissionHelper::RequestPointerLockPermission( void WebViewPermissionHelper::RequestGeolocationPermission( int bridge_id, const GURL& requesting_frame, - bool user_gesture, const base::Callback<void(bool)>& callback) { web_view_permission_helper_delegate_->RequestGeolocationPermission( - bridge_id, requesting_frame, user_gesture, callback); + bridge_id, requesting_frame, callback); } void WebViewPermissionHelper::CancelGeolocationPermissionRequest( diff --git a/extensions/browser/guest_view/web_view/web_view_permission_helper.h b/extensions/browser/guest_view/web_view/web_view_permission_helper.h index 90e1cfd..8383665 100644 --- a/extensions/browser/guest_view/web_view/web_view_permission_helper.h +++ b/extensions/browser/guest_view/web_view/web_view_permission_helper.h @@ -74,7 +74,6 @@ class WebViewPermissionHelper // Requests Geolocation Permission from the embedder. void RequestGeolocationPermission(int bridge_id, const GURL& requesting_frame, - bool user_gesture, const base::Callback<void(bool)>& callback); void CancelGeolocationPermissionRequest(int bridge_id); diff --git a/extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.h b/extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.h index 4f2bdd1..eea7ad4 100644 --- a/extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.h +++ b/extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.h @@ -35,7 +35,6 @@ class WebViewPermissionHelperDelegate : public content::WebContentsObserver { virtual void RequestGeolocationPermission( int bridge_id, const GURL& requesting_frame, - bool user_gesture, const base::Callback<void(bool)>& callback) {} virtual void CancelGeolocationPermissionRequest(int bridge_id) {} |