summaryrefslogtreecommitdiffstats
path: root/extensions/browser/guest_view
diff options
context:
space:
mode:
authorwjmaclean <wjmaclean@chromium.org>2016-02-01 14:54:30 -0800
committerCommit bot <commit-bot@chromium.org>2016-02-01 22:55:58 +0000
commitf89035216b627283b79731c3e6a7957707ed9034 (patch)
treebae27a93918c32402c6af6ad5dd7bf66d320766c /extensions/browser/guest_view
parent1624f7e07304daf5b9872643b713de12c6296b2e (diff)
downloadchromium_src-f89035216b627283b79731c3e6a7957707ed9034.zip
chromium_src-f89035216b627283b79731c3e6a7957707ed9034.tar.gz
chromium_src-f89035216b627283b79731c3e6a7957707ed9034.tar.bz2
Implement webview.captureVisibleRegion()
This CL implements webview.captureVisibleRegion(), an extension/apps API to allow WebView users to capture screenshots of the contents displayed in a WebView. The surfaces contents capture has been plumbed via RenderWidgetHostViewChildFrame so this implementation should not require changes when WebView switches to using OOPIF. As part of the implementation, there are two notable refactors: 1) CaptureWebContentsFunction has been refactored into WebContentsCaptureClient to remove the extensions::AsyncExtensionFunction dependence so that this code can be used by both tabs.captureVisibleTab and webview.captureVisibleRegion, and 2) common code from DelegatedFrameHost has ben moved to content/browser/compositor/surface_utils.* in order to avoid duplication as both DelegatedFrameHost and RenderWidgetHostViewChildFrame now use the code. Finally, this CL adds a surface-drawn callback to RenderWidgetHostViewChildFrame, to allow deferring a screen capture request until a frame has actually been drawn. This callback can be used to simplify some existing tests. BUG=326755 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Review URL: https://codereview.chromium.org/1635513003 Cr-Commit-Position: refs/heads/master@{#372799}
Diffstat (limited to 'extensions/browser/guest_view')
-rw-r--r--extensions/browser/guest_view/web_view/web_view_apitest.cc3
1 files changed, 3 insertions, 0 deletions
diff --git a/extensions/browser/guest_view/web_view/web_view_apitest.cc b/extensions/browser/guest_view/web_view/web_view_apitest.cc
index 9896e13..89bbf05 100644
--- a/extensions/browser/guest_view/web_view/web_view_apitest.cc
+++ b/extensions/browser/guest_view/web_view/web_view_apitest.cc
@@ -736,5 +736,8 @@ IN_PROC_BROWSER_TEST_F(WebViewAPITest, TestWebViewInsideFrame) {
LaunchApp("web_view/inside_iframe");
}
+IN_PROC_BROWSER_TEST_F(WebViewAPITest, TestCaptureVisibleRegion) {
+ RunTest("testCaptureVisibleRegion", "web_view/apitest");
+}
} // namespace extensions