summaryrefslogtreecommitdiffstats
path: root/extensions/browser/mojo
diff options
context:
space:
mode:
authorrockot <rockot@chromium.org>2015-08-22 18:42:04 -0700
committerCommit bot <commit-bot@chromium.org>2015-08-23 01:42:53 +0000
commitbd9bf5a43f904f59ebac4f0982a3e3ddddf61e4b (patch)
tree3c161b06e3a5e95ad142a7f4ea28b0816ba0fb9e /extensions/browser/mojo
parent59c45a7ebc21338ca0bf3b5e10b815a18e9ac7b9 (diff)
downloadchromium_src-bd9bf5a43f904f59ebac4f0982a3e3ddddf61e4b.zip
chromium_src-bd9bf5a43f904f59ebac4f0982a3e3ddddf61e4b.tar.gz
chromium_src-bd9bf5a43f904f59ebac4f0982a3e3ddddf61e4b.tar.bz2
Revert of Update mojo sdk to rev c02a28868825edfa57ab77947b8cb15e741c5598 (patchset #1 id:1 of https://codereview.chromium.org/1310103002/ )
Reason for revert: Looks like this breaks mojo_system_unittests on Android... http://build.chromium.org/p/chromium.linux/buildstatus?builder=Android%20GN&number=29595 Original issue's description: > Update mojo sdk to rev c02a28868825edfa57ab77947b8cb15e741c5598 > > Re-land. Previously conflicted with another CL that landed > just before the roll. > > BUG=None > TBR=jam@chromium.org,ben@chromium.org > TBR=mfoltz@chromium.org > TBR=mek@chromium.org > TBR=xhwang@chromium.org > TBR=shess@chromium.org > > Committed: https://crrev.com/0bfe154baad9ddfb1f0c6ecc7cace36e8f430e75 > Cr-Commit-Position: refs/heads/master@{#344994} TBR=ben@chromium.org,jam@chromium.org,mek@chromium.org,mfoltz@chromium.org,shess@chromium.org,xhwang@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review URL: https://codereview.chromium.org/1309103002 Cr-Commit-Position: refs/heads/master@{#344996}
Diffstat (limited to 'extensions/browser/mojo')
-rw-r--r--extensions/browser/mojo/stash_backend_unittest.cc8
1 files changed, 4 insertions, 4 deletions
diff --git a/extensions/browser/mojo/stash_backend_unittest.cc b/extensions/browser/mojo/stash_backend_unittest.cc
index be76bac..ae14208 100644
--- a/extensions/browser/mojo/stash_backend_unittest.cc
+++ b/extensions/browser/mojo/stash_backend_unittest.cc
@@ -33,7 +33,7 @@ mojo::ScopedHandle CreateReadableHandle() {
} // namespace
-class StashServiceTest : public testing::Test {
+class StashServiceTest : public testing::Test, public mojo::ErrorHandler {
public:
enum Event {
EVENT_NONE,
@@ -49,11 +49,11 @@ class StashServiceTest : public testing::Test {
stash_backend_.reset(new StashBackend(base::Bind(
&StashServiceTest::OnHandleReadyToRead, base::Unretained(this))));
stash_backend_->BindToRequest(mojo::GetProxy(&stash_service_));
- stash_service_.set_connection_error_handler(base::Bind(&OnConnectionError));
+ stash_service_.set_error_handler(this);
handles_ready_ = 0;
}
- static void OnConnectionError() { FAIL() << "Unexpected connection error"; }
+ void OnConnectionError() override { FAIL() << "Unexpected connection error"; }
mojo::Array<StashedObjectPtr> RetrieveStash() {
mojo::Array<StashedObjectPtr> stash;
@@ -271,7 +271,7 @@ TEST_F(StashServiceTest, NotifyOncePerStashOnReadableHandles) {
// exists.
TEST_F(StashServiceTest, ServiceWithDeletedBackend) {
stash_backend_.reset();
- stash_service_.set_connection_error_handler(base::Bind(&OnConnectionError));
+ stash_service_.set_error_handler(this);
mojo::Array<StashedObjectPtr> stashed_objects;
StashedObjectPtr stashed_object(StashedObject::New());