diff options
author | jamescook@chromium.org <jamescook@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-17 17:21:45 +0000 |
---|---|---|
committer | jamescook@chromium.org <jamescook@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-17 17:21:45 +0000 |
commit | 46a19f626f5794f298cd1e4d8bdcbfcb07fd0b4e (patch) | |
tree | 5a04abc6c4c823a4ddf1ca0d76fcc1ea47ff009a /extensions/browser/process_manager_delegate.h | |
parent | dddea5bb5ab70ac91118754eb09ccb30dcb178a2 (diff) | |
download | chromium_src-46a19f626f5794f298cd1e4d8bdcbfcb07fd0b4e.zip chromium_src-46a19f626f5794f298cd1e4d8bdcbfcb07fd0b4e.tar.gz chromium_src-46a19f626f5794f298cd1e4d8bdcbfcb07fd0b4e.tar.bz2 |
Revert 283678 "Refactor code that defers extension background pa..."
This broke Chrome OS valgrind bots, for example:
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%284%29/builds/27033
> Refactor code that defers extension background page loading
>
> src/extensions depends on chrome::NOTIFICATION_PROFILE_CREATED to support deferred loading of extension background pages when the profile isn't ready yet. This is a layering violation.
>
> * Remove Chrome concepts like "browser window ready" and "profile created" from ProcessManager. Introduce ProcessManagerDelegate with a general concept of deferring background page loading.
> * Consolidate all the tricky Chrome-specific background page loading rules into ChromeProcessManagerDelegate. This keeps all the rules in one place. Annotate each block of special case code with the bug that inspired it.
> * Extend unit test coverage for ProcessManager.
>
> This will make it easier to eliminate chrome::NOTIFICATION_PROFILE_DESTROYED in ProcessManager in a later CL.
>
> BUG=392658
> TEST=unit_tests ProcessManagerTest, browser_tests ProcessManagerBrowserTest, manual
>
> Review URL: https://codereview.chromium.org/381283002
TBR=jamescook@chromium.org
Review URL: https://codereview.chromium.org/399153002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283801 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'extensions/browser/process_manager_delegate.h')
-rw-r--r-- | extensions/browser/process_manager_delegate.h | 34 |
1 files changed, 0 insertions, 34 deletions
diff --git a/extensions/browser/process_manager_delegate.h b/extensions/browser/process_manager_delegate.h deleted file mode 100644 index 7cc48c0..0000000 --- a/extensions/browser/process_manager_delegate.h +++ /dev/null @@ -1,34 +0,0 @@ -// Copyright 2014 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#ifndef EXTENSIONS_BROWSER_PROCESS_MANAGER_DELEGATE_H_ -#define EXTENSIONS_BROWSER_PROCESS_MANAGER_DELEGATE_H_ - -namespace content { -class BrowserContext; -}; - -namespace extensions { - -// Customization of ProcessManager for the extension system embedder. -class ProcessManagerDelegate { - public: - virtual ~ProcessManagerDelegate() {} - - // Returns true if the embedder allows background pages for the given - // |context|. - virtual bool IsBackgroundPageAllowed( - content::BrowserContext* context) const = 0; - - // Returns true if the embedder wishes to defer starting up the renderers for - // extension background pages. If the embedder returns true it must call - // ProcessManager::MaybeCreateStartupBackgroundHosts() when it is ready. See - // ChromeProcessManagerDelegate for examples of how this is useful. - virtual bool DeferCreatingStartupBackgroundHosts( - content::BrowserContext* context) const = 0; -}; - -} // namespace extensions - -#endif // EXTENSIONS_BROWSER_PROCESS_MANAGER_DELEGATE_H_ |