diff options
| author | akuegel@chromium.org <akuegel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-05 13:29:30 +0000 |
|---|---|---|
| committer | akuegel@chromium.org <akuegel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-05 13:29:30 +0000 |
| commit | 62d22ec9c7c5171e8c6d2de4899f2703118d6b28 (patch) | |
| tree | 0c19c973b880fdae1ea4e8e033fb0ab8700f66b3 /extensions/browser/process_manager_unittest.cc | |
| parent | baa2b4d423792fac06656a0f39fb343500f68f41 (diff) | |
| download | chromium_src-62d22ec9c7c5171e8c6d2de4899f2703118d6b28.zip chromium_src-62d22ec9c7c5171e8c6d2de4899f2703118d6b28.tar.gz chromium_src-62d22ec9c7c5171e8c6d2de4899f2703118d6b28.tar.bz2 | |
Revert of Resubmit: Remove deprecated extension notifications from ProcessManager (https://codereview.chromium.org/434593002/)
Reason for revert:
Speculative revert, see http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/5773/steps/unit_tests/logs/GetHostZoomMap
The stack trace mentions extensions::ExtensionRegistry::RemoveObserver
Original issue's description:
> Remove deprecated extension notifications from ProcessManager and use ExtensionRegistry instead.
>
> ProcessManagerTest inherts ExtensionsTest for the test settings. So now unit test is passed.
>
> R=rdevlin.cronin@chromium.org
> BUG=354046
> TEST=extensions_unittests
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287521
TBR=rdevlin.cronin@chromium.org,limasdf@gmail.com
NOTREECHECKS=true
NOTRY=true
BUG=354046
Review URL: https://codereview.chromium.org/443623002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287530 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'extensions/browser/process_manager_unittest.cc')
| -rw-r--r-- | extensions/browser/process_manager_unittest.cc | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/extensions/browser/process_manager_unittest.cc b/extensions/browser/process_manager_unittest.cc index 957e3a2..e04b0d3 100644 --- a/extensions/browser/process_manager_unittest.cc +++ b/extensions/browser/process_manager_unittest.cc @@ -111,6 +111,13 @@ TEST_F(ProcessManagerTest, ExtensionNotificationRegistration) { extensions::NOTIFICATION_EXTENSIONS_READY_DEPRECATED, original_context())); EXPECT_TRUE(IsRegistered(manager1.get(), + extensions::NOTIFICATION_EXTENSION_LOADED_DEPRECATED, + original_context())); + EXPECT_TRUE( + IsRegistered(manager1.get(), + extensions::NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED, + original_context())); + EXPECT_TRUE(IsRegistered(manager1.get(), extensions::NOTIFICATION_EXTENSION_HOST_DESTROYED, original_context())); @@ -124,6 +131,11 @@ TEST_F(ProcessManagerTest, ExtensionNotificationRegistration) { EXPECT_EQ(incognito_context(), manager2->GetBrowserContext()); EXPECT_EQ(0u, manager2->background_hosts().size()); + // Some notifications are observed for the original context. + EXPECT_TRUE(IsRegistered(manager2.get(), + extensions::NOTIFICATION_EXTENSION_LOADED_DEPRECATED, + original_context())); + // Some notifications are observed for the incognito context. EXPECT_TRUE(IsRegistered(manager2.get(), extensions::NOTIFICATION_EXTENSION_HOST_DESTROYED, |