summaryrefslogtreecommitdiffstats
path: root/extensions/browser/runtime_data_unittest.cc
diff options
context:
space:
mode:
authordcheng <dcheng@chromium.org>2016-02-26 19:51:32 -0800
committerCommit bot <commit-bot@chromium.org>2016-02-27 03:53:04 +0000
commit794d2bd77811b6d6b45048c19c287075cc9930db (patch)
treeef71bf3826d396a488ef0c72a68b3d7f4ff236d3 /extensions/browser/runtime_data_unittest.cc
parent47dc6a8a0f7d36d20f90df5ac62da075d45bc9c3 (diff)
downloadchromium_src-794d2bd77811b6d6b45048c19c287075cc9930db.zip
chromium_src-794d2bd77811b6d6b45048c19c287075cc9930db.tar.gz
chromium_src-794d2bd77811b6d6b45048c19c287075cc9930db.tar.bz2
Make extensions::DictionaryBuilder and extensions::ListValue unmovable.
There's no reason for these classes to be movable. std::move() is just being used as a synonym for Build(). In addition: - Build() is fewer characters than std::move(). - clang-format works better when builder syntax is consistently used, which makes it easier for readers to visually match up deeply nested builders. - It's surprising to see std::move() used with what looks like a temporary. BUG=none Review URL: https://codereview.chromium.org/1739183003 Cr-Commit-Position: refs/heads/master@{#378107}
Diffstat (limited to 'extensions/browser/runtime_data_unittest.cc')
-rw-r--r--extensions/browser/runtime_data_unittest.cc12
1 files changed, 6 insertions, 6 deletions
diff --git a/extensions/browser/runtime_data_unittest.cc b/extensions/browser/runtime_data_unittest.cc
index 6e522a4..790dd25 100644
--- a/extensions/browser/runtime_data_unittest.cc
+++ b/extensions/browser/runtime_data_unittest.cc
@@ -21,12 +21,12 @@ namespace {
// Creates a very simple extension with a background page.
scoped_refptr<Extension> CreateExtensionWithBackgroundPage() {
return ExtensionBuilder()
- .SetManifest(std::move(
- DictionaryBuilder()
- .Set("name", "test")
- .Set("version", "0.1")
- .Set("background",
- std::move(DictionaryBuilder().Set("page", "bg.html")))))
+ .SetManifest(DictionaryBuilder()
+ .Set("name", "test")
+ .Set("version", "0.1")
+ .Set("background",
+ DictionaryBuilder().Set("page", "bg.html").Build())
+ .Build())
.SetID("id2")
.Build();
}