summaryrefslogtreecommitdiffstats
path: root/extensions/browser/value_store
diff options
context:
space:
mode:
authordcheng <dcheng@chromium.org>2014-10-21 05:38:24 -0700
committerCommit bot <commit-bot@chromium.org>2014-10-21 12:38:39 +0000
commit9168b2fe3e30afa4fd9a9500ba0725edf97c20a3 (patch)
treebb288d5b7fccc259391b83b18b12368a0d516b21 /extensions/browser/value_store
parentae36a4a3f2efd040be2e563b0bff0592b0a5b5a1 (diff)
downloadchromium_src-9168b2fe3e30afa4fd9a9500ba0725edf97c20a3.zip
chromium_src-9168b2fe3e30afa4fd9a9500ba0725edf97c20a3.tar.gz
chromium_src-9168b2fe3e30afa4fd9a9500ba0725edf97c20a3.tar.bz2
Standardize usage of virtual/override/final in extensions/
This patch was automatically generated by applying clang fixit hints generated by the plugin to the source tree. BUG=417463 TBR=yoz@chromium.org Review URL: https://codereview.chromium.org/664933004 Cr-Commit-Position: refs/heads/master@{#300475}
Diffstat (limited to 'extensions/browser/value_store')
-rw-r--r--extensions/browser/value_store/leveldb_value_store.h35
-rw-r--r--extensions/browser/value_store/testing_value_store.h35
2 files changed, 34 insertions, 36 deletions
diff --git a/extensions/browser/value_store/leveldb_value_store.h b/extensions/browser/value_store/leveldb_value_store.h
index 40e1fb6..e94e391 100644
--- a/extensions/browser/value_store/leveldb_value_store.h
+++ b/extensions/browser/value_store/leveldb_value_store.h
@@ -27,26 +27,25 @@ class LeveldbValueStore : public ValueStore {
explicit LeveldbValueStore(const base::FilePath& path);
// Must be deleted on the FILE thread.
- virtual ~LeveldbValueStore();
+ ~LeveldbValueStore() override;
// ValueStore implementation.
- virtual size_t GetBytesInUse(const std::string& key) override;
- virtual size_t GetBytesInUse(const std::vector<std::string>& keys) override;
- virtual size_t GetBytesInUse() override;
- virtual ReadResult Get(const std::string& key) override;
- virtual ReadResult Get(const std::vector<std::string>& keys) override;
- virtual ReadResult Get() override;
- virtual WriteResult Set(
- WriteOptions options,
- const std::string& key,
- const base::Value& value) override;
- virtual WriteResult Set(
- WriteOptions options, const base::DictionaryValue& values) override;
- virtual WriteResult Remove(const std::string& key) override;
- virtual WriteResult Remove(const std::vector<std::string>& keys) override;
- virtual WriteResult Clear() override;
- virtual bool Restore() override;
- virtual bool RestoreKey(const std::string& key) override;
+ size_t GetBytesInUse(const std::string& key) override;
+ size_t GetBytesInUse(const std::vector<std::string>& keys) override;
+ size_t GetBytesInUse() override;
+ ReadResult Get(const std::string& key) override;
+ ReadResult Get(const std::vector<std::string>& keys) override;
+ ReadResult Get() override;
+ WriteResult Set(WriteOptions options,
+ const std::string& key,
+ const base::Value& value) override;
+ WriteResult Set(WriteOptions options,
+ const base::DictionaryValue& values) override;
+ WriteResult Remove(const std::string& key) override;
+ WriteResult Remove(const std::vector<std::string>& keys) override;
+ WriteResult Clear() override;
+ bool Restore() override;
+ bool RestoreKey(const std::string& key) override;
// Write directly to the backing levelDB. Only used for testing to cause
// corruption in the database.
diff --git a/extensions/browser/value_store/testing_value_store.h b/extensions/browser/value_store/testing_value_store.h
index 20faa7d..27df928 100644
--- a/extensions/browser/value_store/testing_value_store.h
+++ b/extensions/browser/value_store/testing_value_store.h
@@ -13,7 +13,7 @@
class TestingValueStore : public ValueStore {
public:
TestingValueStore();
- virtual ~TestingValueStore();
+ ~TestingValueStore() override;
// Sets the error code for requests. If OK, errors won't be thrown.
// Defaults to OK.
@@ -28,25 +28,24 @@ class TestingValueStore : public ValueStore {
int write_count() { return write_count_; }
// ValueStore implementation.
- virtual size_t GetBytesInUse(const std::string& key) override;
- virtual size_t GetBytesInUse(const std::vector<std::string>& keys) override;
- virtual size_t GetBytesInUse() override;
- virtual ReadResult Get(const std::string& key) override;
- virtual ReadResult Get(const std::vector<std::string>& keys) override;
- virtual ReadResult Get() override;
- virtual WriteResult Set(
- WriteOptions options,
- const std::string& key,
- const base::Value& value) override;
- virtual WriteResult Set(
- WriteOptions options, const base::DictionaryValue& values) override;
- virtual WriteResult Remove(const std::string& key) override;
- virtual WriteResult Remove(const std::vector<std::string>& keys) override;
- virtual WriteResult Clear() override;
+ size_t GetBytesInUse(const std::string& key) override;
+ size_t GetBytesInUse(const std::vector<std::string>& keys) override;
+ size_t GetBytesInUse() override;
+ ReadResult Get(const std::string& key) override;
+ ReadResult Get(const std::vector<std::string>& keys) override;
+ ReadResult Get() override;
+ WriteResult Set(WriteOptions options,
+ const std::string& key,
+ const base::Value& value) override;
+ WriteResult Set(WriteOptions options,
+ const base::DictionaryValue& values) override;
+ WriteResult Remove(const std::string& key) override;
+ WriteResult Remove(const std::vector<std::string>& keys) override;
+ WriteResult Clear() override;
// TestingValueStores can't get corrupted (they're all in-memory), so these
// just return true.
- virtual bool Restore() override;
- virtual bool RestoreKey(const std::string& key) override;
+ bool Restore() override;
+ bool RestoreKey(const std::string& key) override;
private:
scoped_ptr<ValueStore::Error> TestingError();