diff options
| author | nick <nick@chromium.org> | 2015-06-03 16:27:42 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-06-03 23:28:19 +0000 |
| commit | 0b08cdaeab9210611012014b9ba7ac93d7efb5c7 (patch) | |
| tree | e6e4e289cddb6adb79e2961c5ee1149d2476ee31 /extensions/browser | |
| parent | 3d81929ed1e99aba25dc364147a34537dd1fe7c7 (diff) | |
| download | chromium_src-0b08cdaeab9210611012014b9ba7ac93d7efb5c7.zip chromium_src-0b08cdaeab9210611012014b9ba7ac93d7efb5c7.tar.gz chromium_src-0b08cdaeab9210611012014b9ba7ac93d7efb5c7.tar.bz2 | |
Histograms.xml python script housekeeping:
- Add an autogeneration script for the bad_message.h files.
- add histogram_paths.py, to help deal with paths consistently.
- Specify filenames relative to src/ in all scripts. This makes
things more greppable, and eliminates a problem where the os-
specific path separator would seep into the histograms.xml
if you ran the scripts on Windows.
- Make the scripts run properly from any directory (previously they
had to be run from the histograms directory).
- Update some docstring comments (google python style)
Changes outside of tools\metrics:
- From bad_message.h files, mention the autogen script.
And finally:
- Run all the scripts, which revealed some neglected enum values.
TEST=Run tools/metrics/.../*.py on Windows
BUG=338781,485227
Review URL: https://codereview.chromium.org/1143323006
Cr-Commit-Position: refs/heads/master@{#332724}
Diffstat (limited to 'extensions/browser')
| -rw-r--r-- | extensions/browser/bad_message.h | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/extensions/browser/bad_message.h b/extensions/browser/bad_message.h index 25a0789..c78cd5b 100644 --- a/extensions/browser/bad_message.h +++ b/extensions/browser/bad_message.h @@ -19,7 +19,9 @@ namespace bad_message { // // NOTE: Do not remove or reorder elements in this list. Add new entries at the // end. Items may be renamed but do not change the values. We rely on the enum -// values in histograms. Also update histograms.xml with any new values. +// values in histograms. Also update histograms.xml with any new values by +// running: +// python tools/metrics/histograms/update_bad_message_reasons.py enum BadMessageReason { EOG_BAD_ORIGIN = 0, EVG_BAD_ORIGIN = 1, |