diff options
| author | sheretov <sheretov@chromium.org> | 2015-01-22 16:38:47 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-01-23 00:40:06 +0000 |
| commit | 8e00ed97c496ae85c95200cd84c63f1696ea85ab (patch) | |
| tree | f978889de480d83d24eced3abf23cb197e4dabfa /extensions/common/BUILD.gn | |
| parent | 09a730fac4fa5075faa85221161ee0b86150c2ae (diff) | |
| download | chromium_src-8e00ed97c496ae85c95200cd84c63f1696ea85ab.zip chromium_src-8e00ed97c496ae85c95200cd84c63f1696ea85ab.tar.gz chromium_src-8e00ed97c496ae85c95200cd84c63f1696ea85ab.tar.bz2 | |
Third attempt at landing:
https://codereview.chromium.org/792353002/
Second attempt is here:
https://codereview.chromium.org/854693002/
The latest build failure affected only linux_chromium_gn_dbg configuration, and was caused by crypto_verify_impl.cc being incorrectly included into the build on Linux.
Patch Set 2 moves the offending crypto_verify_impl.h/cc files into the right fileset that is chromeos-specific.
Original CL description follows:
Refactoring of Cast-related crypto code to use the same certificate validation logic in chrome.networkingPrivate API and Cast Channel authentication.
Here's what's being done here:
* Code from cast_auth_util_nss/openssl formed the basis a common Cast device validation component in /src/extensions/common/cast/cast_cert_validator*, and is now being extensively cleaned up in response to rsleevi's comments in this CL.
* Both networking_private_crypto* and cast_auth_util* have been updated to use the new common code.
* The current D-Bus-based implementation of VerifyDestination is going away per discussion with ChromeOS team, and is replaced with in-Chrome code in networking_private crypto*.
BUG=442650
TBR=rockot@chromium.org,brettw@chromium.org
Review URL: https://codereview.chromium.org/863023002
Cr-Commit-Position: refs/heads/master@{#312715}
Diffstat (limited to 'extensions/common/BUILD.gn')
| -rw-r--r-- | extensions/common/BUILD.gn | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/extensions/common/BUILD.gn b/extensions/common/BUILD.gn index f6dcd00..76e932d 100644 --- a/extensions/common/BUILD.gn +++ b/extensions/common/BUILD.gn @@ -2,6 +2,7 @@ # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. +import("//build/config/crypto.gni") import("//build/config/features.gni") import("//third_party/mojo/src/mojo/public/tools/bindings/mojom.gni") @@ -41,6 +42,8 @@ if (enable_extensions) { "api/sockets/sockets_manifest_handler.h", "api/sockets/sockets_manifest_permission.cc", "api/sockets/sockets_manifest_permission.h", + "cast/cast_cert_validator.cc", + "cast/cast_cert_validator.h", "common_manifest_handlers.cc", "common_manifest_handlers.h", "csp_validator.cc", @@ -249,6 +252,12 @@ if (enable_extensions) { "//url", ] + if (use_openssl) { + sources += [ "cast/cast_cert_validator_openssl.cc" ] + } else { + sources += [ "cast/cast_cert_validator_nss.cc" ] + } + if (enable_nacl) { sources += [ "manifest_handlers/nacl_modules_handler.cc", |