Convert remaining StringToLowerASCII to ToLowerASCII.

Remove StringToLowerASCII. This removes the template and makes a consistent call that can take a string piece.

http_response_headers.cc in HttpResponseHeaders::RemoveHeaderLine there seemed to be a bug where it did
  std::string old_header_name_lowercase(name);
where it actually meant
  std::string old_header_name_lowercase(old_header_name);
I fixed this.

There were a number of cases where url.host() or url.scheme() was passed to ToLowerASCII. These are already guaranteed lower-case, so I removed the call.

There were a number of cases in net that did return ToLowerASCII().c_str() when the return type is a std::string, which is unnecessary and wasteful. I removed the c_str() call.

NOPRESUBMIT=true
(for touching code with wstrings)

Review URL: https://codereview.chromium.org/1282363003

Cr-Commit-Position: refs/heads/master@{#342869}

1 files changed, 3 insertions, 8 deletions

diff --git a/extensions/common/csp_validator.cc b/extensions/common/csp_validator.cc
index 842fc80..8f9406f 100644
--- a/extensions/common/csp_validator.cc
+++ b/extensions/common/csp_validator.cc
@@ -292,9 +292,7 @@ std::string SanitizeContentSecurityPolicy(
     if (!tokenizer.GetNext())
       continue;
 
-    std::string directive_name = tokenizer.token();
-    base::StringToLowerASCII(&directive_name);
-
+    std::string directive_name = base::ToLowerASCII(tokenizer.token_piece());
     if (UpdateStatus(directive_name, &tokenizer, &default_src_status, options,
                      &sane_csp_parts, &default_src_csp_warnings))
       continue;
@@ -348,17 +346,14 @@ bool ContentSecurityPolicyIsSandboxed(
     if (!tokenizer.GetNext())
       continue;
 
-    std::string directive_name = tokenizer.token();
-    base::StringToLowerASCII(&directive_name);
-
+    std::string directive_name = base::ToLowerASCII(tokenizer.token_piece());
     if (directive_name != kSandboxDirectiveName)
       continue;
 
     seen_sandbox = true;
 
     while (tokenizer.GetNext()) {
-      std::string token = tokenizer.token();
-      base::StringToLowerASCII(&token);
+      std::string token = base::ToLowerASCII(tokenizer.token_piece());
 
       // The same origin token negates the sandboxing.
       if (token == kAllowSameOriginToken)