diff options
| author | battre@chromium.org <battre@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-12 00:29:15 +0000 |
|---|---|---|
| committer | battre@chromium.org <battre@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-12 00:29:15 +0000 |
| commit | 6c16475940a16572e1ecd093b96f6ad1e282725a (patch) | |
| tree | 99a4f01a9b4337f8f93d0e2db9fa989d920c6fa8 /extensions/common/extension.cc | |
| parent | bad70b5e1cac23b0930d8c3008a9a47b302b6a29 (diff) | |
| download | chromium_src-6c16475940a16572e1ecd093b96f6ad1e282725a.zip chromium_src-6c16475940a16572e1ecd093b96f6ad1e282725a.tar.gz chromium_src-6c16475940a16572e1ecd093b96f6ad1e282725a.tar.bz2 | |
Limit scope of settings API configuration and proxy permission
The proxy API permission gave an extension super power: It gained complete
incognito permission. This was introduced in r210766 and is reverted here. The
reason for r210766 was that a proxy setting for regular mode was propagated
into incognito mode. This propagation was based on the assumption that
incognito mode inherits most settings from regular mode but has caused lots of
confusion and several bug reports. With this CL, extensions can only affect
settings of incognito mode if they have incognito permission.
BUG=346125,290423
Review URL: https://codereview.chromium.org/184043024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256362 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'extensions/common/extension.cc')
| -rw-r--r-- | extensions/common/extension.cc | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/extensions/common/extension.cc b/extensions/common/extension.cc index d6158c4..8532842 100644 --- a/extensions/common/extension.cc +++ b/extensions/common/extension.cc @@ -450,10 +450,6 @@ bool Extension::can_be_incognito_enabled() const { return !is_platform_app() || location() == Manifest::COMPONENT; } -bool Extension::force_incognito_enabled() const { - return PermissionsData::HasAPIPermission(this, APIPermission::kProxy); -} - void Extension::AddWebExtentPattern(const URLPattern& pattern) { // Bookmark apps are permissionless. if (from_bookmark()) |