diff options
| author | calamity@chromium.org <calamity@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-21 04:53:27 +0000 |
|---|---|---|
| committer | calamity@chromium.org <calamity@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-21 04:53:27 +0000 |
| commit | 83f6ba9b357f78b5348b26bbfb68143cf9b9b415 (patch) | |
| tree | dd3465dffbcf2a4bdff29bd127c148cb84a90eb7 /extensions/common/extension.cc | |
| parent | b1bf19abcbde1ef1e669d72a71e4aab0320e65a9 (diff) | |
| download | chromium_src-83f6ba9b357f78b5348b26bbfb68143cf9b9b415.zip chromium_src-83f6ba9b357f78b5348b26bbfb68143cf9b9b415.tar.gz chromium_src-83f6ba9b357f78b5348b26bbfb68143cf9b9b415.tar.bz2 | |
Make generated bookmark apps have no web extent.
This patch removes web extents from bookmark apps and stops them from
using the launch url as the web extent by default. This was preventing
creation of bookmark apps for any page that was in an overlapping extent
(e.g it wasn't possible to create a bookmark app for drive.google.com/keep
while the default Google Drive app was installed).
This doesn't affect the hosted app security model because bookmark apps
don't use the hosted app process model and have no permissions.
BUG=318607
TBR=dbeam@chromium.org
Review URL: https://codereview.chromium.org/137513003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245983 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'extensions/common/extension.cc')
| -rw-r--r-- | extensions/common/extension.cc | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/extensions/common/extension.cc b/extensions/common/extension.cc index 07e8679..5339ec8 100644 --- a/extensions/common/extension.cc +++ b/extensions/common/extension.cc @@ -455,6 +455,10 @@ bool Extension::force_incognito_enabled() const { } void Extension::AddWebExtentPattern(const URLPattern& pattern) { + // Bookmark apps are permissionless. + if (from_bookmark()) + return; + extent_.AddPattern(pattern); } |