diff options
author | rdevlin.cronin <rdevlin.cronin@chromium.org> | 2015-09-24 15:35:49 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-09-24 22:36:35 +0000 |
commit | e2d0fd0ad14bfd0cd82e0093b1488103af532c8e (patch) | |
tree | c44c2f971ace4bdfcfcc65df42eb629b74cdc40a /extensions/common/extension.cc | |
parent | 8723a2c2a90e060006d1b45a6ce58bacf17bb9d8 (diff) | |
download | chromium_src-e2d0fd0ad14bfd0cd82e0093b1488103af532c8e.zip chromium_src-e2d0fd0ad14bfd0cd82e0093b1488103af532c8e.tar.gz chromium_src-e2d0fd0ad14bfd0cd82e0093b1488103af532c8e.tar.bz2 |
[Extensions] Un-refcount PermissionSet
PermissionSet represents a set of permissions, and for some reason,
it's been refcounted. There's really no reason to have it, and it
makes everything more costly and difficult to reason about. Remove the
refcounting.
Note: This is part 1 of a 2-part series. This removes the ref-counting.
In a followup, I'll go through and update many of the places that
use const PermissionSet* and convert to const &.
BUG=455414
TBR=thestig@chromium.org (misc chrome files with ptr conversion)
TBR=nasko@chromium.org (extension messages - not actually changing any IPC messages)
Review URL: https://codereview.chromium.org/1349613003
Cr-Commit-Position: refs/heads/master@{#350684}
Diffstat (limited to 'extensions/common/extension.cc')
-rw-r--r-- | extensions/common/extension.cc | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/extensions/common/extension.cc b/extensions/common/extension.cc index 9328ba2..024e558 100644 --- a/extensions/common/extension.cc +++ b/extensions/common/extension.cc @@ -781,10 +781,8 @@ UnloadedExtensionInfo::UnloadedExtensionInfo( UpdatedExtensionPermissionsInfo::UpdatedExtensionPermissionsInfo( const Extension* extension, - const PermissionSet* permissions, + const PermissionSet& permissions, Reason reason) - : reason(reason), - extension(extension), - permissions(permissions) {} + : reason(reason), extension(extension), permissions(permissions) {} } // namespace extensions |