diff options
| author | dcheng <dcheng@chromium.org> | 2014-08-25 15:20:01 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-08-25 22:30:35 +0000 |
| commit | 7921e3faac8556ad9e24c533b8019f85b99e6911 (patch) | |
| tree | bdb12163f695a2513b627378f43a1f6ff4803990 /extensions/common/extension_set_unittest.cc | |
| parent | 4dfe65941a184aee51c4540f0f0fed7d03b9ba8a (diff) | |
| download | chromium_src-7921e3faac8556ad9e24c533b8019f85b99e6911.zip chromium_src-7921e3faac8556ad9e24c533b8019f85b99e6911.tar.gz chromium_src-7921e3faac8556ad9e24c533b8019f85b99e6911.tar.bz2 | |
Remove implicit conversions from scoped_refptr to T* in extensions/
This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.
BUG=110610
Review URL: https://codereview.chromium.org/503873002
Cr-Commit-Position: refs/heads/master@{#291770}
Diffstat (limited to 'extensions/common/extension_set_unittest.cc')
| -rw-r--r-- | extensions/common/extension_set_unittest.cc | 29 |
1 files changed, 17 insertions, 12 deletions
diff --git a/extensions/common/extension_set_unittest.cc b/extensions/common/extension_set_unittest.cc index 75a69de..54be17f 100644 --- a/extensions/common/extension_set_unittest.cc +++ b/extensions/common/extension_set_unittest.cc @@ -69,12 +69,12 @@ TEST(ExtensionSetTest, ExtensionSet) { // Add an extension. EXPECT_TRUE(extensions.Insert(ext1)); EXPECT_EQ(1u, extensions.size()); - EXPECT_EQ(ext1, extensions.GetByID(ext1->id())); + EXPECT_EQ(ext1.get(), extensions.GetByID(ext1->id())); // Since extension2 has same ID, it should overwrite extension1. EXPECT_FALSE(extensions.Insert(ext2)); EXPECT_EQ(1u, extensions.size()); - EXPECT_EQ(ext2, extensions.GetByID(ext1->id())); + EXPECT_EQ(ext2.get(), extensions.GetByID(ext1->id())); // Add the other extensions. EXPECT_TRUE(extensions.Insert(ext3)); @@ -82,18 +82,23 @@ TEST(ExtensionSetTest, ExtensionSet) { EXPECT_EQ(3u, extensions.size()); // Get extension by its chrome-extension:// URL - EXPECT_EQ(ext2, extensions.GetExtensionOrAppByURL( - ext2->GetResourceURL("test.html"))); - EXPECT_EQ(ext3, extensions.GetExtensionOrAppByURL( - ext3->GetResourceURL("test.html"))); - EXPECT_EQ(ext4, extensions.GetExtensionOrAppByURL( - ext4->GetResourceURL("test.html"))); + EXPECT_EQ( + ext2.get(), + extensions.GetExtensionOrAppByURL(ext2->GetResourceURL("test.html"))); + EXPECT_EQ( + ext3.get(), + extensions.GetExtensionOrAppByURL(ext3->GetResourceURL("test.html"))); + EXPECT_EQ( + ext4.get(), + extensions.GetExtensionOrAppByURL(ext4->GetResourceURL("test.html"))); // Get extension by web extent. - EXPECT_EQ(ext2, extensions.GetExtensionOrAppByURL( - GURL("http://code.google.com/p/chromium/monkey"))); - EXPECT_EQ(ext3, extensions.GetExtensionOrAppByURL( - GURL("http://dev.chromium.org/design-docs/"))); + EXPECT_EQ(ext2.get(), + extensions.GetExtensionOrAppByURL( + GURL("http://code.google.com/p/chromium/monkey"))); + EXPECT_EQ(ext3.get(), + extensions.GetExtensionOrAppByURL( + GURL("http://dev.chromium.org/design-docs/"))); EXPECT_FALSE(extensions.GetExtensionOrAppByURL( GURL("http://blog.chromium.org/"))); |