summaryrefslogtreecommitdiffstats
path: root/extensions/common/manifest_handlers
diff options
context:
space:
mode:
authorjamescook <jamescook@chromium.org>2015-03-05 12:25:03 -0800
committerCommit bot <commit-bot@chromium.org>2015-03-05 20:25:56 +0000
commit273c9d4f9e88cb81fc20245fbeede5f822e66897 (patch)
tree88bfa179f10ed0d1a235d819a83293476b9d7737 /extensions/common/manifest_handlers
parent05607149af093c3ca020c266e1344178145ad926 (diff)
downloadchromium_src-273c9d4f9e88cb81fc20245fbeede5f822e66897.zip
chromium_src-273c9d4f9e88cb81fc20245fbeede5f822e66897.tar.gz
chromium_src-273c9d4f9e88cb81fc20245fbeede5f822e66897.tar.bz2
Remove unneeded CHECK from OAuth2ManifestHandler
It was there to investigate a crash and has not been triggered in the two months it has been in place. BUG=445683 TEST=extensions_unittests Review URL: https://codereview.chromium.org/984663002 Cr-Commit-Position: refs/heads/master@{#319313}
Diffstat (limited to 'extensions/common/manifest_handlers')
-rw-r--r--extensions/common/manifest_handlers/oauth2_manifest_handler.cc4
1 files changed, 0 insertions, 4 deletions
diff --git a/extensions/common/manifest_handlers/oauth2_manifest_handler.cc b/extensions/common/manifest_handlers/oauth2_manifest_handler.cc
index 3bcf958..1d32ecb 100644
--- a/extensions/common/manifest_handlers/oauth2_manifest_handler.cc
+++ b/extensions/common/manifest_handlers/oauth2_manifest_handler.cc
@@ -53,10 +53,6 @@ bool OAuth2ManifestHandler::Parse(Extension* extension,
return false;
}
- // This should not be possible, but it looks like the source of the crash in
- // http://crbug.com/445683. Perhaps something is overwriting the stack.
- CHECK(info);
-
// HasPath checks for whether the manifest is allowed to have
// oauth2.auto_approve based on whitelist, and if it is present.
// GetBoolean reads the value of auto_approve directly from dict to prevent