diff options
| author | kalman <kalman@chromium.org> | 2014-10-30 17:42:08 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-10-31 00:42:22 +0000 |
| commit | 496b34d93dbf9968d273e1d52f0ebb6f680a4f0c (patch) | |
| tree | 513bb04a6e0d583c24bd46e7a485399469f94ac8 /extensions/common/manifest_handlers | |
| parent | e6633ca726043764a934add484216acc0b24445f (diff) | |
| download | chromium_src-496b34d93dbf9968d273e1d52f0ebb6f680a4f0c.zip chromium_src-496b34d93dbf9968d273e1d52f0ebb6f680a4f0c.tar.gz chromium_src-496b34d93dbf9968d273e1d52f0ebb6f680a4f0c.tar.bz2 | |
Make the default value of open-in-tab false when the options_ui key is given.
Previously it was true to maintain consistency with the options_page key, but
this introduces more complexity than it avoids for extension developers.
BUG=414920
R=rockot@chromium.org
Review URL: https://codereview.chromium.org/670623004
Cr-Commit-Position: refs/heads/master@{#302200}
Diffstat (limited to 'extensions/common/manifest_handlers')
| -rw-r--r-- | extensions/common/manifest_handlers/options_page_info.cc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/extensions/common/manifest_handlers/options_page_info.cc b/extensions/common/manifest_handlers/options_page_info.cc index efcff83..a8bb4d6 100644 --- a/extensions/common/manifest_handlers/options_page_info.cc +++ b/extensions/common/manifest_handlers/options_page_info.cc @@ -144,6 +144,7 @@ scoped_ptr<OptionsPageInfo> OptionsPageInfo::Create( } if (options_ui->chrome_style.get()) chrome_style = *options_ui->chrome_style; + open_in_tab = false; if (options_ui->open_in_tab.get()) open_in_tab = *options_ui->open_in_tab; } |