diff options
| author | jamescook <jamescook@chromium.org> | 2015-01-06 09:54:52 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-01-06 17:55:33 +0000 |
| commit | ec299aa0ff64e7b4647d376c93d6927ecc85d070 (patch) | |
| tree | c84b0d27be840c790c47041276bb2d8e136ead2a /extensions/common/manifest_handlers | |
| parent | 25a73d005e46ac0b9e8499e4c51f8c6305b56e87 (diff) | |
| download | chromium_src-ec299aa0ff64e7b4647d376c93d6927ecc85d070.zip chromium_src-ec299aa0ff64e7b4647d376c93d6927ecc85d070.tar.gz chromium_src-ec299aa0ff64e7b4647d376c93d6927ecc85d070.tar.bz2 | |
Add a CHECK to investigate crash in OAuth2ManifestHandler::Parse
I don't see anything wrong with the code, so adding a CHECK to investigate
further. If there are no crashes on this CHECK it can be removed in M42.
BUG=445683
TEST=extensions_unittests
Review URL: https://codereview.chromium.org/832333008
Cr-Commit-Position: refs/heads/master@{#310107}
Diffstat (limited to 'extensions/common/manifest_handlers')
| -rw-r--r-- | extensions/common/manifest_handlers/oauth2_manifest_handler.cc | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/extensions/common/manifest_handlers/oauth2_manifest_handler.cc b/extensions/common/manifest_handlers/oauth2_manifest_handler.cc index 1d32ecb..3bcf958 100644 --- a/extensions/common/manifest_handlers/oauth2_manifest_handler.cc +++ b/extensions/common/manifest_handlers/oauth2_manifest_handler.cc @@ -53,6 +53,10 @@ bool OAuth2ManifestHandler::Parse(Extension* extension, return false; } + // This should not be possible, but it looks like the source of the crash in + // http://crbug.com/445683. Perhaps something is overwriting the stack. + CHECK(info); + // HasPath checks for whether the manifest is allowed to have // oauth2.auto_approve based on whitelist, and if it is present. // GetBoolean reads the value of auto_approve directly from dict to prevent |