summaryrefslogtreecommitdiffstats
path: root/extensions/common/permissions
diff options
context:
space:
mode:
authorrockot <rockot@chromium.org>2015-11-13 09:29:26 -0800
committerCommit bot <commit-bot@chromium.org>2015-11-13 17:30:08 +0000
commit39a7fbf4435ec5ac461eedc721b7f22a70b287aa (patch)
tree2402943676aa0b83dc9f71ca2c8824d98cf88d0d /extensions/common/permissions
parent425442d790da1ee851b70eabe69aea224e5b13c9 (diff)
downloadchromium_src-39a7fbf4435ec5ac461eedc721b7f22a70b287aa.zip
chromium_src-39a7fbf4435ec5ac461eedc721b7f22a70b287aa.tar.gz
chromium_src-39a7fbf4435ec5ac461eedc721b7f22a70b287aa.tar.bz2
Change extensions enum presubmit checks to run on upload only
This reverts commit 64749d907f25d5cb7241b90be42a22d52b4c02bc to re-enable extensions enum presubmit checks, but makes them run on upload only so false positives don't block commits. BUG=555540 R=thakis@chromium.org,rdevlin.cronin@chromium.org TBR=phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/1440343003 Cr-Commit-Position: refs/heads/master@{#359572}
Diffstat (limited to 'extensions/common/permissions')
-rw-r--r--extensions/common/permissions/PRESUBMIT.py32
1 files changed, 32 insertions, 0 deletions
diff --git a/extensions/common/permissions/PRESUBMIT.py b/extensions/common/permissions/PRESUBMIT.py
new file mode 100644
index 0000000..1a07050
--- /dev/null
+++ b/extensions/common/permissions/PRESUBMIT.py
@@ -0,0 +1,32 @@
+# Copyright 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""Chromium presubmit script for src/extensions/common/permissions.
+
+See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
+for more details on the presubmit API built into depot_tools.
+"""
+import sys
+
+def GetPreferredTrySlaves():
+ return ['linux_chromeos']
+
+def _CreateAPIPermissionIDChecker(input_api, output_api):
+ original_sys_path = sys.path
+
+ try:
+ sys.path.append(input_api.os_path.join(
+ input_api.PresubmitLocalPath(), '..', '..', '..', 'tools',
+ 'strict_enum_value_checker'))
+ from strict_enum_value_checker import StrictEnumValueChecker
+ finally:
+ sys.path = original_sys_path
+
+ return StrictEnumValueChecker(input_api, output_api,
+ start_marker=' enum ID {', end_marker=' // Last entry:',
+ path='extensions/common/permissions/api_permission.h')
+
+def CheckChangeOnUpload(input_api, output_api):
+ return _CreateAPIPermissionIDChecker(input_api, output_api).Run()
+