Make extensions::DictionaryBuilder and extensions::ListValue unmovable.

There's no reason for these classes to be movable. std::move() is just
being used as a synonym for Build().

In addition:
- Build() is fewer characters than std::move().
- clang-format works better when builder syntax is consistently used,
  which makes it easier for readers to visually match up deeply nested
  builders.
- It's surprising to see std::move() used with what looks like a
  temporary.

BUG=none

Review URL: https://codereview.chromium.org/1739183003

Cr-Commit-Position: refs/heads/master@{#378107}

1 files changed, 19 insertions, 15 deletions

diff --git a/extensions/common/test_util.cc b/extensions/common/test_util.cc
index e3775e5..c065c29 100644
--- a/extensions/common/test_util.cc
+++ b/extensions/common/test_util.cc
@@ -14,39 +14,43 @@ namespace extensions {
 namespace test_util {
 
 ExtensionBuilder BuildExtension(ExtensionBuilder builder) {
-  builder.SetManifest(std::move(DictionaryBuilder()
-                                    .Set("name", "Test extension")
-                                    .Set("version", "1.0")
-                                    .Set("manifest_version", 2)));
+  builder.SetManifest(DictionaryBuilder()
+                          .Set("name", "Test extension")
+                          .Set("version", "1.0")
+                          .Set("manifest_version", 2)
+                          .Build());
   return builder;
 }
 
 ExtensionBuilder BuildApp(ExtensionBuilder builder) {
-  builder.SetManifest(std::move(
+  builder.SetManifest(
       DictionaryBuilder()
           .Set("name", "Test extension")
           .Set("version", "1.0")
           .Set("manifest_version", 2)
-          .Set("app",
-               std::move(extensions::DictionaryBuilder().Set(
-                   "background",
-                   std::move(extensions::DictionaryBuilder().Set(
-                       "scripts", std::move(extensions::ListBuilder().Append(
-                                      "background.js")))))))));
+          .Set("app", extensions::DictionaryBuilder()
+                          .Set("background",
+                               extensions::DictionaryBuilder()
+                                   .Set("scripts", extensions::ListBuilder()
+                                                       .Append("background.js")
+                                                       .Build())
+                                   .Build())
+                          .Build())
+          .Build());
   return builder;
 }
 
 scoped_refptr<Extension> CreateEmptyExtension() {
   return ExtensionBuilder()
-      .SetManifest(std::move(
-          DictionaryBuilder().Set("name", "Test").Set("version", "1.0")))
+      .SetManifest(
+          DictionaryBuilder().Set("name", "Test").Set("version", "1.0").Build())
       .Build();
 }
 
 scoped_refptr<Extension> CreateEmptyExtension(const std::string& id) {
   return ExtensionBuilder()
-      .SetManifest(std::move(
-          DictionaryBuilder().Set("name", "test").Set("version", "0.1")))
+      .SetManifest(
+          DictionaryBuilder().Set("name", "test").Set("version", "0.1").Build())
       .SetID(id)
       .Build();
 }