diff options
author | jamescook <jamescook@chromium.org> | 2014-09-16 10:02:08 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-09-16 17:03:09 +0000 |
commit | bd1cc624f6fd9761409ee8a8ac5cfd3a5896c87a (patch) | |
tree | 4efb6754a787762a7a8677af63dd21fee160e36d /extensions/common/test_util.h | |
parent | d575eafb4f112ed0c0f4be8cf58dfb8f71d4a142 (diff) | |
download | chromium_src-bd1cc624f6fd9761409ee8a8ac5cfd3a5896c87a.zip chromium_src-bd1cc624f6fd9761409ee8a8ac5cfd3a5896c87a.tar.gz chromium_src-bd1cc624f6fd9761409ee8a8ac5cfd3a5896c87a.tar.bz2 |
Refactor ExtensionManifestTest to allow usage in src/extensions
This refactor will allow some manifest tests running in Chrome's unit_tests
suite to move to the extensions_unittests suite.
* Rename ExtensionManifestTest to extensions::ManifestTest and move it into
src/extensions.
* Introduce ChromeManifestTest to load manifests from Chrome's test data dir.
* Eliminate some unnecessary use of chrome::VersionInfo::Channel.
* Move SharedModuleManifestTest to extensions_unittests as an example.
FileHandlerManifestTest and ExternallyConnectableManifestTest will be next,
but require more refactoring (e.g. of permissions).
BUG=397165
TEST=unit_tests, extensions_unittests
Review URL: https://codereview.chromium.org/572813002
Cr-Commit-Position: refs/heads/master@{#295087}
Diffstat (limited to 'extensions/common/test_util.h')
-rw-r--r-- | extensions/common/test_util.h | 11 |
1 files changed, 0 insertions, 11 deletions
diff --git a/extensions/common/test_util.h b/extensions/common/test_util.h index 46ac5d08..862c469 100644 --- a/extensions/common/test_util.h +++ b/extensions/common/test_util.h @@ -8,11 +8,6 @@ #include <string> #include "base/memory/ref_counted.h" -#include "base/memory/scoped_ptr.h" - -namespace base { -class DictionaryValue; -} // namespace base namespace extensions { class Extension; @@ -30,12 +25,6 @@ scoped_refptr<Extension> CreateEmptyExtension(); // Return a very simple extension with a given |id|. scoped_refptr<Extension> CreateExtensionWithID(const std::string& id); -// Parses |json| allowing trailing commas and replacing single quotes with -// double quotes for test readability. If the json fails to parse, calls gtest's -// ADD_FAILURE and returns an empty dictionary. -scoped_ptr<base::DictionaryValue> ParseJsonDictionaryWithSingleQuotes( - std::string json); - } // namespace test_util } // namespace extensions |