summaryrefslogtreecommitdiffstats
path: root/extensions/common
diff options
context:
space:
mode:
authordtseng <dtseng@chromium.org>2016-02-04 16:07:31 -0800
committerCommit bot <commit-bot@chromium.org>2016-02-05 00:08:32 +0000
commit44a33be0211fae0485f4e77b8c7d6c5190069066 (patch)
treeef5eafa89c01aa7c7ee572d56e5bc063547ce84c /extensions/common
parent39fdddde9fa0d94d661a158934713dded8f2a152 (diff)
downloadchromium_src-44a33be0211fae0485f4e77b8c7d6c5190069066.zip
chromium_src-44a33be0211fae0485f4e77b8c7d6c5190069066.tar.gz
chromium_src-44a33be0211fae0485f4e77b8c7d6c5190069066.tar.bz2
Fix various issues seen in onScrollPositionChanged
onScrollPosition changed: - accesses |Output| without setting any speech or braille to output. This causes access of a substring to return undefined and subsequently, a call to toString on an undefined object. - onScrollPositionChanged does not respect ChromeVox mode (so likely will draw active indicator when the event gets fired after compat/classic mode switch which sets a ChromeVox range) - it accesses state/location/boundsForRange on objects like webArea that seem to return undefined by the automation API. This violates our externs, so always get the externs to align with their actual usage. State is always defined, the others are sometimes undefined. TEST=manual BUG=581161 Review URL: https://codereview.chromium.org/1632093002 Cr-Commit-Position: refs/heads/master@{#373671}
Diffstat (limited to 'extensions/common')
0 files changed, 0 insertions, 0 deletions