[Closure Externs] Add more APIs to the presubmit warning list

Add a bunch of private APIs to the list that will get presubmit checks. Also
normalize the paths and check that each exists.

BUG=469920

Review URL: https://codereview.chromium.org/1761663002

Cr-Commit-Position: refs/heads/master@{#380488}

2 files changed, 12 insertions, 1 deletions

diff --git a/extensions/common/api/externs_checker.py b/extensions/common/api/externs_checker.py
index 58c0076..fd60fdd 100644
--- a/extensions/common/api/externs_checker.py
+++ b/extensions/common/api/externs_checker.py
@@ -12,6 +12,10 @@ class ExternsChecker(object):
     self._output_api = output_api
     self._api_pairs = api_pairs
 
+    for path in api_pairs.keys() + api_pairs.values():
+      if not input_api.os_path.exists(path):
+        raise OSError('Path Not Found: %s' % path)
+
   def RunChecks(self):
     bad_files = []
     affected = [f.AbsoluteLocalPath() for f in self._input_api.AffectedFiles()]
diff --git a/extensions/common/api/externs_checker_test.py b/extensions/common/api/externs_checker_test.py
index 73b65fa..9bcc651 100755
--- a/extensions/common/api/externs_checker_test.py
+++ b/extensions/common/api/externs_checker_test.py
@@ -18,8 +18,9 @@ from PRESUBMIT_test_mocks import MockInputApi, MockOutputApi, MockFile
 class ExternsCheckerTest(unittest.TestCase):
   API_PAIRS = {'a': '1', 'b': '2', 'c': '3'}
 
-  def _runChecks(self, files):
+  def _runChecks(self, files, exists=lambda f: True):
     input_api = MockInputApi()
+    input_api.os_path.exists = exists
     input_api.files = [MockFile(f, '') for f in files]
     output_api = MockOutputApi()
     checker = ExternsChecker(input_api, output_api, self.API_PAIRS)
@@ -58,6 +59,12 @@ class ExternsCheckerTest(unittest.TestCase):
     self.assertEquals(1, len(results[0].items))
     self.assertEquals('c', results[0].items[0])
 
+  def testApiFileDoesNotExist(self):
+    exists = lambda f: f in ['a', 'b', 'c', '1', '2']
+    with self.assertRaises(OSError) as e:
+      self._runChecks(['a'], exists)
+    self.assertEqual('Path Not Found: 3', str(e.exception))
+
 
 if __name__ == '__main__':
   unittest.main()