diff options
| author | schenney <schenney@chromium.org> | 2015-06-22 06:20:33 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-06-22 13:21:03 +0000 |
| commit | 21d068fd8a2094ea45cb067a22c8f8bd87c4b1be (patch) | |
| tree | 16157ba7967381159e0412e910009dce73f5c116 /extensions/components | |
| parent | 5822cda7e0efb18da9b846a8876387cdf6e8e75c (diff) | |
| download | chromium_src-21d068fd8a2094ea45cb067a22c8f8bd87c4b1be.zip chromium_src-21d068fd8a2094ea45cb067a22c8f8bd87c4b1be.tar.gz chromium_src-21d068fd8a2094ea45cb067a22c8f8bd87c4b1be.tar.bz2 | |
Revert of [MacViews] Implement AppWindowNativeWidgetMac::Maximize. (patchset #5 id:80001 of https://codereview.chromium.org/1184643003/)
Reason for revert:
This seems the most likely cause of a reliable Mac browser test failure.
e.g https://build.chromium.org/p/chromium.webkit/builders/Mac10.6%20Tests/builds/29726
Original issue's description:
> [MacViews] Implement AppWindowNativeWidgetMac::Maximize.
>
> This makes MacViews behavior consistent with the existing Cocoa
> implementation and adds a heap of tests for interactions between
> Minimize, Restore, Maximize, and Fullscreen.
>
> This also changes NativeAppWindowCocoa behavior to be more
> consistent with other platforms:
> - isMaximized, isMinimized, isFullscreen are mutually exclusive,
> - maximize() shows the window if it is minimized,
> - restore() always restores the window size (in addition to unminimizing
> and exiting fullscreen).
>
> This also fixes a bug in the Cocoa implementation where Maximize
> changes the window frame while in fullscreen.
>
> BUG=459877
>
> Committed: https://crrev.com/5c69ddcaa25a8d5a6963a7cab4bb6b6e5e636b78
> Cr-Commit-Position: refs/heads/master@{#335465}
TBR=tapted@chromium.org,jackhou@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=459877
Review URL: https://codereview.chromium.org/1192373006
Cr-Commit-Position: refs/heads/master@{#335493}
Diffstat (limited to 'extensions/components')
| -rw-r--r-- | extensions/components/native_app_window/native_app_window_views.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/extensions/components/native_app_window/native_app_window_views.cc b/extensions/components/native_app_window/native_app_window_views.cc index 0233623..e80e852 100644 --- a/extensions/components/native_app_window/native_app_window_views.cc +++ b/extensions/components/native_app_window/native_app_window_views.cc @@ -44,10 +44,10 @@ void NativeAppWindowViews::Init(AppWindow* app_window, Observe(app_window_->web_contents()); widget_ = new views::Widget; - widget_->AddObserver(this); InitializeWindow(app_window, create_params); OnViewWasResized(); + widget_->AddObserver(this); } NativeAppWindowViews::~NativeAppWindowViews() { |