diff options
| author | jackhou <jackhou@chromium.org> | 2015-06-23 16:56:33 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-06-23 23:57:06 +0000 |
| commit | eec1f9ce243632da8a4fede1c086c3ce8f1f24c4 (patch) | |
| tree | 284c30df0b17576e70a5593f1c0364ae55c6bfa8 /extensions/components | |
| parent | b41583252bca8d30ad4b796eddbee07578f022c8 (diff) | |
| download | chromium_src-eec1f9ce243632da8a4fede1c086c3ce8f1f24c4.zip chromium_src-eec1f9ce243632da8a4fede1c086c3ce8f1f24c4.tar.gz chromium_src-eec1f9ce243632da8a4fede1c086c3ce8f1f24c4.tar.bz2 | |
[MacViews] Implement AppWindowNativeWidgetMac::Maximize.
This makes MacViews behavior consistent with the existing Cocoa
implementation and adds a heap of tests for interactions between
Minimize, Restore, Maximize, and Fullscreen.
This also changes NativeAppWindowCocoa behavior to be more
consistent with other platforms:
- isMaximized, isMinimized, isFullscreen are mutually exclusive,
- maximize() shows the window if it is minimized,
- restore() always restores the window size (in addition to unminimizing
and exiting fullscreen).
This also fixes a bug in the Cocoa implementation where Maximize
changes the window frame while in fullscreen.
BUG=459877, 503208
Committed: https://crrev.com/5c69ddcaa25a8d5a6963a7cab4bb6b6e5e636b78
Cr-Commit-Position: refs/heads/master@{#335465}
Review URL: https://codereview.chromium.org/1184643003
Cr-Commit-Position: refs/heads/master@{#335812}
Diffstat (limited to 'extensions/components')
| -rw-r--r-- | extensions/components/native_app_window/native_app_window_views.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/extensions/components/native_app_window/native_app_window_views.cc b/extensions/components/native_app_window/native_app_window_views.cc index e80e852..0233623 100644 --- a/extensions/components/native_app_window/native_app_window_views.cc +++ b/extensions/components/native_app_window/native_app_window_views.cc @@ -44,10 +44,10 @@ void NativeAppWindowViews::Init(AppWindow* app_window, Observe(app_window_->web_contents()); widget_ = new views::Widget; + widget_->AddObserver(this); InitializeWindow(app_window, create_params); OnViewWasResized(); - widget_->AddObserver(this); } NativeAppWindowViews::~NativeAppWindowViews() { |