diff options
| author | sammc <sammc@chromium.org> | 2014-09-14 19:47:31 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-09-15 02:49:50 +0000 |
| commit | 32a6fc7d37cf7c6e921779664bc02bbc353add57 (patch) | |
| tree | 783b0dd702934d6e606929590e8038dc8e2b00f4 /extensions/renderer/api | |
| parent | fba512c9255e9ede5748775d4bb5a10934159389 (diff) | |
| download | chromium_src-32a6fc7d37cf7c6e921779664bc02bbc353add57.zip chromium_src-32a6fc7d37cf7c6e921779664bc02bbc353add57.tar.gz chromium_src-32a6fc7d37cf7c6e921779664bc02bbc353add57.tar.bz2 | |
Fix some leaks and failures under valgrind in JS extensions unit tests.
This change:
- Adds running the GC until the v8 heap size reaches steady state during
ModuleSystemTest::TearDown. This is necessary to ensure that
gin::Wrappable objects are freed, as finalizers for JS objects aren't
run during isolate shut down.
- Removes a racy check that failed under valgrind.
BUG=389016,406487
Review URL: https://codereview.chromium.org/502893002
Cr-Commit-Position: refs/heads/master@{#294779}
Diffstat (limited to 'extensions/renderer/api')
| -rw-r--r-- | extensions/renderer/api/serial/serial_api_unittest.cc | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/extensions/renderer/api/serial/serial_api_unittest.cc b/extensions/renderer/api/serial/serial_api_unittest.cc index 6dc01eb..e511d30 100644 --- a/extensions/renderer/api/serial/serial_api_unittest.cc +++ b/extensions/renderer/api/serial/serial_api_unittest.cc @@ -409,12 +409,6 @@ class SerialApiTest : public ApiTestBase { &SerialApiTest::CreateSerialService, base::Unretained(this))); } - virtual void TearDown() OVERRIDE { - if (io_handler_.get()) - EXPECT_TRUE(io_handler_->HasOneRef()); - ApiTestBase::TearDown(); - } - scoped_refptr<TestIoHandlerBase> io_handler_; private: |