diff options
| author | tsergeant <tsergeant@chromium.org> | 2016-03-09 22:20:44 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-03-10 06:22:01 +0000 |
| commit | 34828570d298a402b6964cdfa99521c74c507faa (patch) | |
| tree | 12ed96b546c18d0bcb60e1dcc1919ce02272dbf7 /extensions/renderer/api_test_base.cc | |
| parent | 9f3b2065a4a7c592677559090e9faa84eea19555 (diff) | |
| download | chromium_src-34828570d298a402b6964cdfa99521c74c507faa.zip chromium_src-34828570d298a402b6964cdfa99521c74c507faa.tar.gz chromium_src-34828570d298a402b6964cdfa99521c74c507faa.tar.bz2 | |
Revert of Use v8::MicrotasksScope internally in V8RecursionScope. (patchset #6 id:100001 of https://codereview.chromium.org/1743763004/ )
Reason for revert:
This CL appears to be causing test failures on Linux ChromiumOS Tests (dbg)(1).
See:
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/12424
Tests are failing with:
Fatal error in ../../v8/src/api.cc, line 166
Check failed: handle_scope_implementer->GetMicrotasksScopeDepth() || !handle_scope_implementer->DebugMicrotasksScopeDepthIsZero()
Original issue's description:
> Use v8::MicrotasksScope internally in V8RecursionScope.
>
> If this sticks we can just remove V8RecursionScope and WebScopedMicrotaskSuppression,
> along with other cleanups.
>
> Attempt #2. Previous one broke GinJavaBridgeValueConverterTest.TypedArrays.
>
> BUG=585949
>
> Committed: https://crrev.com/95a3bd544fe93629b209797d3251423f3d674463
> Cr-Commit-Position: refs/heads/master@{#380033}
TBR=jochen@chromium.org,adamk@chromium.org,dgozman@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=585949
Review URL: https://codereview.chromium.org/1777183002
Cr-Commit-Position: refs/heads/master@{#380356}
Diffstat (limited to 'extensions/renderer/api_test_base.cc')
| -rw-r--r-- | extensions/renderer/api_test_base.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/extensions/renderer/api_test_base.cc b/extensions/renderer/api_test_base.cc index 79f95e2..abf868b 100644 --- a/extensions/renderer/api_test_base.cc +++ b/extensions/renderer/api_test_base.cc @@ -214,7 +214,7 @@ void ApiTestEnvironment::RunTestInner(const std::string& test_name, } void ApiTestEnvironment::RunPromisesAgain() { - v8::MicrotasksScope::PerformCheckpoint(env()->isolate()); + env()->isolate()->RunMicrotasks(); base::MessageLoop::current()->PostTask( FROM_HERE, base::Bind(&ApiTestEnvironment::RunPromisesAgain, base::Unretained(this))); |