diff options
author | tfarina <tfarina@chromium.org> | 2015-04-29 10:03:40 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-04-29 17:04:18 +0000 |
commit | f85316f2347d04f10ecc1bb8114aec6a9cd5c87a (patch) | |
tree | acfb466ba16e2bd06acc2e08c49f7ab9368e1348 /extensions/renderer/console.cc | |
parent | a5bea75424e5db11fbcdb2a99b2ccd6d4868cf65 (diff) | |
download | chromium_src-f85316f2347d04f10ecc1bb8114aec6a9cd5c87a.zip chromium_src-f85316f2347d04f10ecc1bb8114aec6a9cd5c87a.tar.gz chromium_src-f85316f2347d04f10ecc1bb8114aec6a9cd5c87a.tar.bz2 |
extensions/renderer: Use v8::Local instead of v8::Handle.
Turns out, Handle is just an alias for Local:
https://chromium.googlesource.com/v8/v8.git/+/master/include/v8.h#334
BUG=424445
R=scheib@chromium.org
Review URL: https://codereview.chromium.org/1115563002
Cr-Commit-Position: refs/heads/master@{#327515}
Diffstat (limited to 'extensions/renderer/console.cc')
-rw-r--r-- | extensions/renderer/console.cc | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/extensions/renderer/console.cc b/extensions/renderer/console.cc index 3ed31fc..172c5915 100644 --- a/extensions/renderer/console.cc +++ b/extensions/renderer/console.cc @@ -27,14 +27,14 @@ namespace { // contexts in each RenderView. class ByContextFinder : public content::RenderViewVisitor { public: - static content::RenderView* Find(v8::Handle<v8::Context> context) { + static content::RenderView* Find(v8::Local<v8::Context> context) { ByContextFinder finder(context); content::RenderView::ForEach(&finder); return finder.found_; } private: - explicit ByContextFinder(v8::Handle<v8::Context> context) + explicit ByContextFinder(v8::Local<v8::Context> context) : context_(context), found_(NULL) {} bool Visit(content::RenderView* render_view) override { @@ -48,7 +48,7 @@ class ByContextFinder : public content::RenderViewVisitor { return !found_; } - v8::Handle<v8::Context> context_; + v8::Local<v8::Context> context_; content::RenderView* found_; DISALLOW_COPY_AND_ASSIGN(ByContextFinder); @@ -63,7 +63,7 @@ void CheckWithMinidump(const std::string& message) { CHECK(false) << message; } -typedef void (*LogMethod)(v8::Handle<v8::Context> context, +typedef void (*LogMethod)(v8::Local<v8::Context> context, const std::string& message); void BoundLogMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info) { @@ -139,28 +139,28 @@ void AddMessage(content::RenderView* render_view, blink::WebConsoleMessage(target_level, base::UTF8ToUTF16(message))); } -void Debug(v8::Handle<v8::Context> context, const std::string& message) { +void Debug(v8::Local<v8::Context> context, const std::string& message) { AddMessage(context, content::CONSOLE_MESSAGE_LEVEL_DEBUG, message); } -void Log(v8::Handle<v8::Context> context, const std::string& message) { +void Log(v8::Local<v8::Context> context, const std::string& message) { AddMessage(context, content::CONSOLE_MESSAGE_LEVEL_LOG, message); } -void Warn(v8::Handle<v8::Context> context, const std::string& message) { +void Warn(v8::Local<v8::Context> context, const std::string& message) { AddMessage(context, content::CONSOLE_MESSAGE_LEVEL_WARNING, message); } -void Error(v8::Handle<v8::Context> context, const std::string& message) { +void Error(v8::Local<v8::Context> context, const std::string& message) { AddMessage(context, content::CONSOLE_MESSAGE_LEVEL_ERROR, message); } -void Fatal(v8::Handle<v8::Context> context, const std::string& message) { +void Fatal(v8::Local<v8::Context> context, const std::string& message) { Error(context, message); CheckWithMinidump(message); } -void AddMessage(v8::Handle<v8::Context> context, +void AddMessage(v8::Local<v8::Context> context, content::ConsoleMessageLevel level, const std::string& message) { if (context.IsEmpty()) { |